| Message ID | 1410274249-3469-2-git-send-email-nick.dyer@itdev.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 09, 2014 at 03:50:48PM +0100, nick.dyer@itdev.co.uk wrote: > From: Nick Dyer <nick.dyer@itdev.co.uk> > > In the case where the CHG/interrupt line mode is not configured correctly, > this warning is output to dmesg output for each interrupt. Downgrade the > message to debug. > > Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> Applied, thank you. > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c > index db178ed..d954b81 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -837,7 +837,12 @@ static irqreturn_t mxt_process_messages_t44(struct mxt_data *data) > count = data->msg_buf[0]; > > if (count == 0) { > - dev_warn(dev, "Interrupt triggered but zero messages\n"); > + /* > + * This condition is caused by the CHG line being configured > + * in Mode 0. It results in unnecessary I2C operations but it > + * is benign. > + */ > + dev_dbg(dev, "Interrupt triggered but zero messages\n"); > return IRQ_NONE; > } else if (count > data->max_reportid) { > dev_err(dev, "T44 count %d exceeded max report id\n", count); > -- > 1.9.1 >
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index db178ed..d954b81 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -837,7 +837,12 @@ static irqreturn_t mxt_process_messages_t44(struct mxt_data *data) count = data->msg_buf[0]; if (count == 0) { - dev_warn(dev, "Interrupt triggered but zero messages\n"); + /* + * This condition is caused by the CHG line being configured + * in Mode 0. It results in unnecessary I2C operations but it + * is benign. + */ + dev_dbg(dev, "Interrupt triggered but zero messages\n"); return IRQ_NONE; } else if (count > data->max_reportid) { dev_err(dev, "T44 count %d exceeded max report id\n", count);