From patchwork Mon Nov 10 10:56:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Nicoletti X-Patchwork-Id: 5265371 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 16C7C9F2ED for ; Mon, 10 Nov 2014 10:57:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2F47D20166 for ; Mon, 10 Nov 2014 10:57:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C78F2015D for ; Mon, 10 Nov 2014 10:57:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752334AbaKJK5G (ORCPT ); Mon, 10 Nov 2014 05:57:06 -0500 Received: from mail-qc0-f177.google.com ([209.85.216.177]:36000 "EHLO mail-qc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752386AbaKJK5F (ORCPT ); Mon, 10 Nov 2014 05:57:05 -0500 Received: by mail-qc0-f177.google.com with SMTP id l6so5412388qcy.8 for ; Mon, 10 Nov 2014 02:57:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; bh=LBVFiRE93Tni8d1rFLCD1vJSTtWfSpCYxUeA/vsaTrk=; b=hUHz3lfOin4wdkyub8zFZHUzl5MFTxNUJ6Aw+RkzHD8BcpObd9hmWm938smC/jJgvK 8511lP7V2ezhbWth+s/LoeMb1i54e4+vb5c/mYvixcTr6RzW0AE7PjTHJZ2IYERfF5Z+ XcBNZ1NSY8a3twrAWUaZRfrMYv+zGfRpUwVErWHiCueNRRGlq4cNKA2kj864H4q+CA8y mNpvv/2d/XDT61hHZnj4uf2WjUvwZu0yxWvnSbsXm7KZrA6BdDtlrZ2yymQA9IsMQbB2 f8YZWidXxjSIItSPVMY3GiIRybp8QzhzHbL4YwW46K+nU2aWeLy3Y8kPYsGKHNOpcmPw 7HLg== X-Received: by 10.140.20.175 with SMTP id 44mr39876624qgj.22.1415617024205; Mon, 10 Nov 2014 02:57:04 -0800 (PST) Received: from new-host-4.home (177.206.122.134.dynamic.adsl.gvt.net.br. [177.206.122.134]) by mx.google.com with ESMTPSA id f73sm15203227qge.1.2014.11.10.02.57.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Nov 2014 02:57:03 -0800 (PST) Message-ID: <1415617019.16803.2.camel@bart> Subject: Re: PATCH change for HID_BATTERY_STRENGTH kconfig From: Daniel Nicoletti To: Jiri Kosina Cc: linux-input@vger.kernel.org Date: Mon, 10 Nov 2014 08:56:59 -0200 In-Reply-To: References: X-Mailer: Evolution 3.12.2-1b2 Mime-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Em Ter, 2014-07-29 às 13:39 +0200, Jiri Kosina escreveu: > On Mon, 23 Jun 2014, Daniel Nicoletti wrote: > > > 2013-05-23 19:16 GMT-03:00 Jiri Kosina : > > > On Mon, 13 May 2013, Daniel Nicoletti wrote: > > > > > >> Hi, > > >> I'd like to propose this patch while removes the need for > > >> hid to be compiled build-in, as this is the same behavior > > >> that WiiMote and Wacom have. > > >> Is this ok? > > > > > > Makes sense to me. Could you please resend with proper changelog and > > > Signed-off-by: line? > > > > > > Thanks. > > > > Sorry it took more than a year for me to do this, > > so I called git send-email, and so far the CC and > > linux-input didn't get it, tho it said result OK. > > git send-email --to "Jiri Kosina " --cc > > "linux-input@vger.kernel.org" > > 0001-HID-Allows-for-HID_BATTERY_STRENGTH-config-be-enable.patch > > > > I'm pasting it here hoping gmail doesn't screw > > it, if you prefer that I send it using the above > > command mind you telling what I did wrong? > > > > Thanks. > > > > >From df740fd81dffbb74e13c622392fe9a945006fd3c Mon Sep 17 00:00:00 2001 > > From: Daniel Nicoletti > > Date: Mon, 23 Jun 2014 10:31:47 -0300 > > Subject: [PATCH] HID: Allows for HID_BATTERY_STRENGTH config be enabled > > without the need for HID module to be built-in. > > > > It'd be nice to insert a few sentences of changelog here. > > Thanks. > > > Signed-off-by: Daniel Nicoletti > > --- > > drivers/hid/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > > index fb52f3f..d6d85ad 100644 > > --- a/drivers/hid/Kconfig > > +++ b/drivers/hid/Kconfig > > @@ -27,7 +27,8 @@ if HID > > > > config HID_BATTERY_STRENGTH > > bool "Battery level reporting for HID devices" > > - depends on HID && POWER_SUPPLY && HID = POWER_SUPPLY > > + depends on HID > > + select POWER_SUPPLY > > default n > > ---help--- > > This option adds support of reporting battery strength (for HID devices > > -- > > 2.0.0 > > > > -- > Jiri Kosina > SUSE Labs Sorry for yet another delay here is the patch with a better changelog (I hope so)... From 21608873917dcec012c7f9f1b84dd44774069de2 Mon Sep 17 00:00:00 2001 From: Daniel Nicoletti Date: Mon, 23 Jun 2014 10:31:47 -0300 Subject: [PATCH] HID: Allow HID_BATTERY_STRENGTH to be enabled Allows for HID_BATTERY_STRENGTH config be enabled without the need for HID module to be built-in, prior to this HID and POWER_SUPPLY had to be equal, and now we only select POWER_SUPPLY and depend on the HID module. Signed-off-by: Daniel Nicoletti Reviewed-by: David Herrmann --- drivers/hid/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) devices diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index f42df4d..602ac07 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -27,7 +27,8 @@ if HID config HID_BATTERY_STRENGTH bool "Battery level reporting for HID devices" - depends on HID && POWER_SUPPLY && HID = POWER_SUPPLY + depends on HID + select POWER_SUPPLY default n ---help--- This option adds support of reporting battery strength (for HID