From patchwork Wed Nov 19 08:37:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dudley Du X-Patchwork-Id: 5335321 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4FAF29FD49 for ; Wed, 19 Nov 2014 08:42:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 50234201BB for ; Wed, 19 Nov 2014 08:42:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 499B7200FE for ; Wed, 19 Nov 2014 08:42:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755112AbaKSImE (ORCPT ); Wed, 19 Nov 2014 03:42:04 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:63268 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755100AbaKSImD (ORCPT ); Wed, 19 Nov 2014 03:42:03 -0500 Received: by mail-pa0-f43.google.com with SMTP id kx10so135861pab.30 for ; Wed, 19 Nov 2014 00:42:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yTUbjlLzdQxiIfhqdB2+YCcNG5LHPBI4bpxJse9A6qs=; b=dyGzani8WYNWdQHlu7Q9b8rOruaZgPw4veA/k1uBoMdOGjj1vEX2v7hgyrBrHY1xp4 csaYuRAasnHdP9W8a27OIIcOAotgsOsJRd7P+bsYnqNFXOTdTHR/kBM6WM9/JjOxQFyX gQgFR2h23jAPJw/GZQyeRcDdbYZ3vZo1LM5f3GFjSqQVfUaQvPXdPjaNK/M6iDhFUG/j KqCvjOsY5J+p9MzDT1s4UZ1MYIaXSAQUviCPF+nxhcLQmCg6459MwVVayyi5/KYDK/Df pweu9Zw+WNQQYdCcGlToP8R3EQ85dtW7HZrLJVu77t8jgsCWAofkSbbMbmWuN38WdCbY rIyw== X-Received: by 10.68.202.1 with SMTP id ke1mr44012719pbc.60.1416386522284; Wed, 19 Nov 2014 00:42:02 -0800 (PST) Received: from localhost ([140.207.206.26]) by mx.google.com with ESMTPSA id ap5sm1205893pad.22.2014.11.19.00.41.59 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 19 Nov 2014 00:42:01 -0800 (PST) From: Dudley Du To: dmitry.torokhov@gmail.com, rydberg@euromail.se Cc: Dudley Du , bleung@google.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v11 17/19] input: cyapa: add read sensors raw data debugfs interface support Date: Wed, 19 Nov 2014 16:37:49 +0800 Message-Id: <1416386271-28167-18-git-send-email-dudley.dulixin@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1416386271-28167-1-git-send-email-dudley.dulixin@gmail.com> References: <1416386271-28167-1-git-send-email-dudley.dulixin@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add read sensors' raw data from trackpad device interface supported in cyapa driver through debugfs raw_data interface. Through this interface, user can read difference count map of each sensors directly from trackpad device (some customers want). And it's useful to help users to find out the root cause when there is performance gap happened. TEST=test on Chromebooks. Signed-off-by: Dudley Du --- drivers/input/mouse/cyapa.c | 105 ++++++++++++++++++++++++++++++++++++++++++++ drivers/input/mouse/cyapa.h | 4 ++ 2 files changed, 109 insertions(+) diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c index 2e394c0..ca31119 100644 --- a/drivers/input/mouse/cyapa.c +++ b/drivers/input/mouse/cyapa.c @@ -34,6 +34,7 @@ #define CYAPA_ADAPTER_FUNC_BOTH 3 #define CYAPA_DEBUGFS_READ_FW "read_fw" +#define CYAPA_DEBUGFS_RAW_DATA "raw_data" #define CYAPA_FW_NAME "cyapa.bin" const char unique_str[] = "CYTRA"; @@ -604,6 +605,106 @@ static const struct file_operations cyapa_read_fw_fops = { .read = cyapa_debugfs_read_fw }; +static int cyapa_debugfs_raw_data_open(struct inode *inode, struct file *file) +{ + struct cyapa *cyapa = inode->i_private; + int error; + + if (!cyapa) + return -ENODEV; + + /* Start to be supported after Gen5 trackpad devices. */ + if (cyapa->gen < CYAPA_GEN5) + return -ENOTSUPP; + + error = mutex_lock_interruptible(&cyapa->debugfs_mutex); + if (error) + return error; + + if (!get_device(&cyapa->client->dev)) { + error = -ENODEV; + goto out; + } + + file->private_data = cyapa; + + /* + * Enale IRQ for raw data read command, and must be enable during + * the whole process. + */ + error = mutex_lock_interruptible(&cyapa->state_sync_lock); + if (error) + goto out; + cyapa_enable_irq_for_cmd(cyapa); + mutex_unlock(&cyapa->state_sync_lock); +out: + mutex_unlock(&cyapa->debugfs_mutex); + return error; +} + +static int cyapa_debugfs_raw_data_release(struct inode *inode, + struct file *file) +{ + struct cyapa *cyapa = file->private_data; + int error; + + if (!cyapa) + return 0; + + /* Disable IRQ if enabled when raw_data file was opened. */ + mutex_lock(&cyapa->state_sync_lock); + cyapa_disable_irq_for_cmd(cyapa); + mutex_unlock(&cyapa->state_sync_lock); + + error = mutex_lock_interruptible(&cyapa->debugfs_mutex); + if (error) + return error; + file->private_data = NULL; + put_device(&cyapa->client->dev); + mutex_unlock(&cyapa->debugfs_mutex); + + return 0; +} + +/* Always return the sensors' latest raw data from trackpad device. */ +static ssize_t cyapa_debugfs_read_raw_data(struct file *file, + char __user *buffer, + size_t count, loff_t *ppos) +{ + int error; + struct cyapa *cyapa = file->private_data; + + error = mutex_lock_interruptible(&cyapa->state_sync_lock); + if (error) + return error; + + if (cyapa->ops->read_raw_data) + error = cyapa->ops->read_raw_data(cyapa); + else + error = -EPERM; + mutex_unlock(&cyapa->state_sync_lock); + if (error) + return error; + + if (*ppos >= cyapa->tp_raw_data_size) + return 0; + + if (count + *ppos > cyapa->tp_raw_data_size) + count = cyapa->tp_raw_data_size - *ppos; + + if (copy_to_user(buffer, &cyapa->tp_raw_data[*ppos], count)) + return -EFAULT; + + *ppos += count; + return count; +} + +static const struct file_operations cyapa_read_raw_data_fops = { + .open = cyapa_debugfs_raw_data_open, + .release = cyapa_debugfs_raw_data_release, + .read = cyapa_debugfs_read_raw_data +}; + static int cyapa_debugfs_init(struct cyapa *cyapa) { struct device *dev = &cyapa->client->dev; @@ -622,6 +723,10 @@ static int cyapa_debugfs_init(struct cyapa *cyapa) debugfs_create_file(CYAPA_DEBUGFS_READ_FW, S_IRUSR, cyapa->dentry_dev, cyapa, &cyapa_read_fw_fops); + if (cyapa->gen >= CYAPA_GEN5) + debugfs_create_file(CYAPA_DEBUGFS_RAW_DATA, S_IRUSR, + cyapa->dentry_dev, cyapa, &cyapa_read_raw_data_fops); + return 0; } diff --git a/drivers/input/mouse/cyapa.h b/drivers/input/mouse/cyapa.h index b6e1b22..9dbf92f 100644 --- a/drivers/input/mouse/cyapa.h +++ b/drivers/input/mouse/cyapa.h @@ -187,6 +187,7 @@ struct cyapa_dev_ops { struct device_attribute *, const char *, size_t); int (*read_fw)(struct cyapa *); + int (*read_raw_data)(struct cyapa *); int (*initialize)(struct cyapa *cyapa); @@ -308,6 +309,9 @@ struct cyapa { struct cyapa_tsg_bin_image_head fw_img_head; u8 *fw_image; size_t fw_image_size; + /* Buffer to store sensors' raw data */ + u8 *tp_raw_data; + size_t tp_raw_data_size; const struct cyapa_dev_ops *ops;