From patchwork Tue Dec 16 00:50:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Wu X-Patchwork-Id: 5498901 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6C57E9F456 for ; Tue, 16 Dec 2014 00:50:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 95FCE209F5 for ; Tue, 16 Dec 2014 00:50:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD7F52099F for ; Tue, 16 Dec 2014 00:50:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750796AbaLPAuf (ORCPT ); Mon, 15 Dec 2014 19:50:35 -0500 Received: from lekensteyn.nl ([178.21.112.251]:46594 "EHLO lekensteyn.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbaLPAud (ORCPT ); Mon, 15 Dec 2014 19:50:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lekensteyn.nl; s=s2048-2014-q3; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=6Zg4ePJMCp/J5WIprHiE58ZPWofODLvQle22kwIMQYs=; b=WrnLErIQWqpVfjQbPZiFa+qnFbif2RqF4vM7wSWx0OymvtX/7wzpeG624yv8EMZqaWFMfk/yEZQFI5m5jYaqW4lPcOp2xksd5fpPENTDneN+o0rKvR5QnbdC29/5l1BHHFo78tB280iONXC83mynKKhUhJZ+jDnelv0Eji4oV6p5JcxHNXWuTVtgl9LSBR6bS1jSaT07UlC1eBoSZeEcphGwu2781iKEqzPPgzk/kUgbd85HIiepRl3iL1C32ZnRDI9zn/a79txJ0JOXfGeTeOxB39W4YB8tT30BJGxpO3cdI16Wc4RwL+c5PuURVxHHUoIrlUuvvAIoFL6IT4TRjA==; Received: by lekensteyn.nl with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA256:128) (Exim 4.80) (envelope-from ) id 1Y0gLJ-0006lu-4P; Tue, 16 Dec 2014 01:50:25 +0100 From: Peter Wu To: Jiri Kosina , Benjamin Tissoires , Nestor Lopez Casado Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] HID: logitech-hidpp: avoid unintended fall-through Date: Tue, 16 Dec 2014 01:50:16 +0100 Message-Id: <1418691016-30681-4-git-send-email-peter@lekensteyn.nl> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1418691016-30681-1-git-send-email-peter@lekensteyn.nl> References: <1418691016-30681-1-git-send-email-peter@lekensteyn.nl> X-Spam-Score: 0.0 (/) X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add a return to avoid a fall-through. Introduced in commit 57ac86cf52e903d9e3e0f12b34c814cce6b65550 ("HID: logitech-hidpp: add support of the first Logitech Wireless Touchpad"). Signed-off-by: Peter Wu --- drivers/hid/hid-logitech-hidpp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 2315358..09eee17 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -811,6 +811,7 @@ static int wtp_raw_event(struct hid_device *hdev, u8 *data, int size) input_event(wd->input, EV_KEY, BTN_RIGHT, !!(data[1] & 0x02)); input_sync(wd->input); + return 0; } else { if (size < 21) return 1;