| Message ID | 1422679082.8722.1.camel@phoenix (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/31/2015 05:38 AM, Axel Lin wrote: > This is a I2C driver, so it's wrong to use platform prefix for the modalias. > We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, > so remove the wrong and unneeded cap11xx modalias. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> Acked-by: Daniel Mack <linux@zonque.org> Thanks! Daniel > --- > drivers/input/keyboard/cap11xx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c > index 4f59f0b..f07461a 100644 > --- a/drivers/input/keyboard/cap11xx.c > +++ b/drivers/input/keyboard/cap11xx.c > @@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = { > > module_i2c_driver(cap11xx_i2c_driver); > > -MODULE_ALIAS("platform:cap11xx"); > MODULE_DESCRIPTION("Microchip CAP11XX driver"); > MODULE_AUTHOR("Daniel Mack <linux@zonque.org>"); > MODULE_LICENSE("GPL v2"); > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Matt Ranostay <mranostay@gmail.com> Thanks, Matt Ranostay On Fri, Jan 30, 2015 at 8:38 PM, Axel Lin <axel.lin@ingics.com> wrote: > This is a I2C driver, so it's wrong to use platform prefix for the modalias. > We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, > so remove the wrong and unneeded cap11xx modalias. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/input/keyboard/cap11xx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c > index 4f59f0b..f07461a 100644 > --- a/drivers/input/keyboard/cap11xx.c > +++ b/drivers/input/keyboard/cap11xx.c > @@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = { > > module_i2c_driver(cap11xx_i2c_driver); > > -MODULE_ALIAS("platform:cap11xx"); > MODULE_DESCRIPTION("Microchip CAP11XX driver"); > MODULE_AUTHOR("Daniel Mack <linux@zonque.org>"); > MODULE_LICENSE("GPL v2"); > -- > 1.9.1 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Jan 31, 2015 at 12:38:02PM +0800, Axel Lin wrote: > This is a I2C driver, so it's wrong to use platform prefix for the modalias. > We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, > so remove the wrong and unneeded cap11xx modalias. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> Applied, thank you. > --- > drivers/input/keyboard/cap11xx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c > index 4f59f0b..f07461a 100644 > --- a/drivers/input/keyboard/cap11xx.c > +++ b/drivers/input/keyboard/cap11xx.c > @@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = { > > module_i2c_driver(cap11xx_i2c_driver); > > -MODULE_ALIAS("platform:cap11xx"); > MODULE_DESCRIPTION("Microchip CAP11XX driver"); > MODULE_AUTHOR("Daniel Mack <linux@zonque.org>"); > MODULE_LICENSE("GPL v2"); > -- > 1.9.1 > > >
diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c index 4f59f0b..f07461a 100644 --- a/drivers/input/keyboard/cap11xx.c +++ b/drivers/input/keyboard/cap11xx.c @@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = { module_i2c_driver(cap11xx_i2c_driver); -MODULE_ALIAS("platform:cap11xx"); MODULE_DESCRIPTION("Microchip CAP11XX driver"); MODULE_AUTHOR("Daniel Mack <linux@zonque.org>"); MODULE_LICENSE("GPL v2");
This is a I2C driver, so it's wrong to use platform prefix for the modalias. We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, so remove the wrong and unneeded cap11xx modalias. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/input/keyboard/cap11xx.c | 1 - 1 file changed, 1 deletion(-)