| Message ID | 1423143083.14425.34.camel@hadess.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2015-02-05 at 14:31 +0100, Bastien Nocera wrote: > KEY_HOME is the key to go back to the beginning of the line, not > the key to get into an overview mode, as Windows does. GNOME can already > make use of the Windows key on multiple form factors, and other > desktop environments can use it depending on the form factor. > > Using "Windows" as the emitted key also means that the keycode sent out > matches the symbol on the key itself. > > So switch KEY_HOME to KEY_LEFTMETA ("Windows" key). Disregard that one, I forgot the SoB... -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c index 79cc0f7..e8e010a 100644 --- a/drivers/input/misc/soc_button_array.c +++ b/drivers/input/misc/soc_button_array.c @@ -195,7 +195,7 @@ static int soc_button_probe(struct platform_device *pdev) static struct soc_button_info soc_button_PNP0C40[] = { { "power", 0, EV_KEY, KEY_POWER, false, true }, - { "home", 1, EV_KEY, KEY_HOME, false, true }, + { "home", 1, EV_KEY, KEY_LEFTMETA, false, true }, { "volume_up", 2, EV_KEY, KEY_VOLUMEUP, true, false }, { "volume_down", 3, EV_KEY, KEY_VOLUMEDOWN, true, false }, { "rotation_lock", 4, EV_SW, SW_ROTATE_LOCK, false, false },
KEY_HOME is the key to go back to the beginning of the line, not the key to get into an overview mode, as Windows does. GNOME can already make use of the Windows key on multiple form factors, and other desktop environments can use it depending on the form factor. Using "Windows" as the emitted key also means that the keycode sent out matches the symbol on the key itself. So switch KEY_HOME to KEY_LEFTMETA ("Windows" key). --- drivers/input/misc/soc_button_array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)