diff mbox

input: edt-ft5x06, Add i2c device ids

Message ID 1424447785-14337-1-git-send-email-mpa@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Markus Pargmann Feb. 20, 2015, 3:56 p.m. UTC 
These ids are necessary to use edt-ft5x06 as a kernel module. Otherwise
it is not loaded automatically in userspace because the ids do not match.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 drivers/input/touchscreen/edt-ft5x06.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Dmitry Torokhov Feb. 20, 2015, 6:32 p.m. UTC | #1 
Hi Markus,

On Fri, Feb 20, 2015 at 04:56:25PM +0100, Markus Pargmann wrote:
> These ids are necessary to use edt-ft5x06 as a kernel module. Otherwise
> it is not loaded automatically in userspace because the ids do not match.
> 

We already have all module aliases needed, please fix i2c to generate modalias
for devices described in OF properly.

> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
>  drivers/input/touchscreen/edt-ft5x06.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index d4c24fb7704f..63ad6d545bbe 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -1119,6 +1119,9 @@ static SIMPLE_DEV_PM_OPS(edt_ft5x06_ts_pm_ops,
>  
>  static const struct i2c_device_id edt_ft5x06_ts_id[] = {
>  	{ "edt-ft5x06", 0, },
> +	{ "edt-ft5206", 0, },
> +	{ "edt-ft5306", 0, },
> +	{ "edt-ft5406", 0, },
>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(i2c, edt_ft5x06_ts_id);
> -- 
> 2.1.4
> 

Thanks.
Markus Pargmann Feb. 23, 2015, 10:06 p.m. UTC | #2 
Hi Dmitry,

On Fri, Feb 20, 2015 at 10:32:50AM -0800, Dmitry Torokhov wrote:
> Hi Markus,
> 
> On Fri, Feb 20, 2015 at 04:56:25PM +0100, Markus Pargmann wrote:
> > These ids are necessary to use edt-ft5x06 as a kernel module. Otherwise
> > it is not loaded automatically in userspace because the ids do not match.
> > 
> 
> We already have all module aliases needed, please fix i2c to generate modalias
> for devices described in OF properly.

Yes, that's probably the better way to fix it. I will have a look into this.

Thanks,

Markus
diff mbox

Patch

diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index d4c24fb7704f..63ad6d545bbe 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -1119,6 +1119,9 @@  static SIMPLE_DEV_PM_OPS(edt_ft5x06_ts_pm_ops,
 
 static const struct i2c_device_id edt_ft5x06_ts_id[] = {
 	{ "edt-ft5x06", 0, },
+	{ "edt-ft5206", 0, },
+	{ "edt-ft5306", 0, },
+	{ "edt-ft5406", 0, },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(i2c, edt_ft5x06_ts_id);