From patchwork Thu Feb 26 23:20:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathias Gottschlag X-Patchwork-Id: 5896701 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B565A9F37F for ; Thu, 26 Feb 2015 23:20:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E6D1420374 for ; Thu, 26 Feb 2015 23:20:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0902B203AD for ; Thu, 26 Feb 2015 23:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754326AbbBZXU0 (ORCPT ); Thu, 26 Feb 2015 18:20:26 -0500 Received: from mail-we0-f181.google.com ([74.125.82.181]:42584 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754648AbbBZXUZ (ORCPT ); Thu, 26 Feb 2015 18:20:25 -0500 Received: by wesw62 with SMTP id w62so15653611wes.9; Thu, 26 Feb 2015 15:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IwggAzdxBWLqVdioP5S5cKyQ5W7/5YeFn9ghr1I2JiQ=; b=KIt7u+3AXxDQmgU5c6MOOlUjMm9C5THS3XoMuXS1DiBTnsqlURt0qFMD76oBF93d5e csq7yyoRfN7egAjUHpBYskMat59WWXU7R+aTTVMWL4f5rdSKk0IA/PwsWpiCO3MsoaQ+ F/BKS+6vdxxi8wyOxkRbqXv2ANggPmLwPk2pm94ydoBPcuj2mqoyGhlYrVgmwXyI7L9o 6d9jRzZ5tTMejz6nFKQnySsJdlj1d0EDyZRYvZK+3XIV5tsMV9Jdi2V9oZEDlazIas+C ioVpS9W1FN+LfdlL5jAy4WoCNNL/z/6YiBAMoQk/65e9G1xLmYRKRHAz9IGd7rnZZT80 NlZw== X-Received: by 10.194.60.77 with SMTP id f13mr21803386wjr.105.1424992823804; Thu, 26 Feb 2015 15:20:23 -0800 (PST) Received: from mathias-laptop.lan (HSI-KBW-37-209-111-36.hsi15.kabel-badenwuerttemberg.de. [37.209.111.36]) by mx.google.com with ESMTPSA id q10sm3408376wjr.41.2015.02.26.15.20.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Feb 2015 15:20:23 -0800 (PST) From: Mathias Gottschlag To: Dmitry Torokhov Cc: Hans de Goede , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Mathias Gottschlag Subject: [PATCHv2 4/4] psmouse: Disable "palm detection" in the focaltech driver. Date: Fri, 27 Feb 2015 00:20:08 +0100 Message-Id: <1424992808-29891-5-git-send-email-mgottschlag@gmail.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1424992808-29891-1-git-send-email-mgottschlag@gmail.com> References: <1423940502-12353-1-git-send-email-mgottschlag@gmail.com> <1424992808-29891-1-git-send-email-mgottschlag@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Apparently, the threshold for large contact area seems to be rather low on some devices, causing the touchpad to frequently freeze during normal usage. Because we do now know how we are supposed to use the value in question, this commit just drops the related code completely. Signed-off-by: Mathias Gottschlag --- drivers/input/mouse/focaltech.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/input/mouse/focaltech.c b/drivers/input/mouse/focaltech.c index d96a847..e1d084a 100644 --- a/drivers/input/mouse/focaltech.c +++ b/drivers/input/mouse/focaltech.c @@ -185,16 +185,6 @@ static void focaltech_process_abs_packet(struct psmouse *psmouse, state->pressed = (packet[0] >> 4) & 1; - /* - * packet[5] contains some kind of tool size in the most - * significant nibble. 0xff is a special value (latching) that - * signals a large contact area. - */ - if (packet[5] == 0xff) { - state->fingers[finger].valid = false; - return; - } - state->fingers[finger].x = ((packet[1] & 0xf) << 8) | packet[2]; state->fingers[finger].y = (packet[3] << 8) | packet[4]; state->fingers[finger].valid = true;