diff mbox

elan_i2c: Add ACPI ID "ELAN1000"

Message ID 1441137231-615-1-git-send-email-jprvita@endlessm.com (mailing list archive)
State New, archived
Headers show

Commit Message

João Paulo Rechi Vita Sept. 1, 2015, 7:53 p.m. UTC
This ACPI ID present in the DSDT of the ASUS E202SA laptop.

Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
---
 drivers/input/mouse/elan_i2c_core.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Dmitry Torokhov Sept. 1, 2015, 9 p.m. UTC | #1
On Tue, Sep 1, 2015 at 12:53 PM, João Paulo Rechi Vita
<jprvita@gmail.com> wrote:
> This ACPI ID present in the DSDT of the ASUS E202SA laptop.

Can it be driven buy the standard hid-multitouch by any chance?

>
> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
> ---
>  drivers/input/mouse/elan_i2c_core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
> index d4a38ca..5e45402 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -1170,6 +1170,7 @@ static const struct acpi_device_id elan_acpi_id[] = {
>         { "ELAN0000", 0 },
>         { "ELAN0100", 0 },
>         { "ELAN0600", 0 },
> +       { "ELAN1000", 0 },
>         { }
>  };
>  MODULE_DEVICE_TABLE(acpi, elan_acpi_id);
> --
> 2.1.4
>
João Paulo Rechi Vita Sept. 1, 2015, 9:15 p.m. UTC | #2
Hello Dmitry, thanks for the feedback.

On 1 September 2015 at 17:00, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On Tue, Sep 1, 2015 at 12:53 PM, João Paulo Rechi Vita
> <jprvita@gmail.com> wrote:
>> This ACPI ID present in the DSDT of the ASUS E202SA laptop.
>
> Can it be driven buy the standard hid-multitouch by any chance?
>

Without this change on v4.2 it is driven by i2c_hid, but behaves as a
regular mouse, so no absolute events, multitouch, tap to click etc. I
have not tried to use hid-multitouch with this touchpad, as I thought
hid-multitouch was a touchscreen driver. Is there any drawback in
having this supported by elan_i2c? Should I try a different approach?

--
João Paulo Rechi Vita
http://about.me/jprvita
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dmitry Torokhov Sept. 3, 2015, 5:06 p.m. UTC | #3
On Tue, Sep 01, 2015 at 05:15:55PM -0400, João Paulo Rechi Vita wrote:
> Hello Dmitry, thanks for the feedback.
> 
> On 1 September 2015 at 17:00, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > On Tue, Sep 1, 2015 at 12:53 PM, João Paulo Rechi Vita
> > <jprvita@gmail.com> wrote:
> >> This ACPI ID present in the DSDT of the ASUS E202SA laptop.
> >
> > Can it be driven buy the standard hid-multitouch by any chance?
> >
> 
> Without this change on v4.2 it is driven by i2c_hid, but behaves as a
> regular mouse, so no absolute events, multitouch, tap to click etc. I
> have not tried to use hid-multitouch with this touchpad, as I thought
> hid-multitouch was a touchscreen driver. Is there any drawback in
> having this supported by elan_i2c? Should I try a different approach?

No, that is fine, I was just checking. Applied, thank you.
diff mbox

Patch

diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index d4a38ca..5e45402 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -1170,6 +1170,7 @@  static const struct acpi_device_id elan_acpi_id[] = {
 	{ "ELAN0000", 0 },
 	{ "ELAN0100", 0 },
 	{ "ELAN0600", 0 },
+	{ "ELAN1000", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, elan_acpi_id);