From patchwork Mon Sep 14 16:53:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 7177611 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B9B17BEEC1 for ; Mon, 14 Sep 2015 16:53:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D5FE320612 for ; Mon, 14 Sep 2015 16:53:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 883502056C for ; Mon, 14 Sep 2015 16:53:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755529AbbINQxc (ORCPT ); Mon, 14 Sep 2015 12:53:32 -0400 Received: from mail-bn1bon0117.outbound.protection.outlook.com ([157.56.111.117]:22432 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752409AbbINQxb (ORCPT ); Mon, 14 Sep 2015 12:53:31 -0400 Received: from BLUPR03CA004.namprd03.prod.outlook.com (10.255.124.21) by BLUPR03MB1380.namprd03.prod.outlook.com (10.163.81.139) with Microsoft SMTP Server (TLS) id 15.1.268.17; Mon, 14 Sep 2015 16:53:29 +0000 Received: from BY2FFO11FD003.protection.gbl (10.255.124.4) by BLUPR03CA004.outlook.office365.com (10.255.124.21) with Microsoft SMTP Server (TLS) id 15.1.268.17 via Frontend Transport; Mon, 14 Sep 2015 16:53:28 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; Received-SPF: Fail (protection.outlook.com: domain of freescale.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD003.mail.protection.outlook.com (10.1.14.125) with Microsoft SMTP Server (TLS) id 15.1.262.18 via Frontend Transport; Mon, 14 Sep 2015 16:53:28 +0000 Received: from fabio-Latitude-E6410.am.freescale.net (fabio-Latitude-E6410.am.freescale.net [10.29.244.190]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id t8EGrOfI017259; Mon, 14 Sep 2015 09:53:26 -0700 From: Fabio Estevam To: CC: , , Fabio Estevam Subject: [PATCH 2/4] Input: touchscreen - Check for negative return value Date: Mon, 14 Sep 2015 13:53:18 -0300 Message-ID: <1442249600-666-2-git-send-email-fabio.estevam@freescale.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1442249600-666-1-git-send-email-fabio.estevam@freescale.com> References: <1442249600-666-1-git-send-email-fabio.estevam@freescale.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD003; 1:BfIWpnC7Q1SYZNOdm/OAA2HrHn/L9/xkjY85mY8jSBrFBhwCpvGr2Vi2yJn9uErQzxi2DZ6wO21g01WGUabrQdwfGO37dC/kNewJrk4xn+lCK27mBB3NyRj63saziWynhC1eOPOXI7ha3AKVao9tI1In3ezPibBnE3Fs5PnxMhSxmKIKA+plFpPz+KVh/fqJdEtqE9QjW72m1wbdnZ09cVF7I6GHsFefkF/Z050nraQ4+8jybAa0xTpmtNAAs/z5C+Hlx63V7t8hGMgUnLcagrNxnYRbCCm1DKs/30QVLpkFC631BJSCL8A7PThSZwwPgqhO94pW40WdNOn4MKKK7adJDpKzekvUatUuv31sXAcz8SY8meeGFByxBSI89Wpc6Ahbm9erI9Ul9ub/3tewZQ== X-Forefront-Antispam-Report: CIP:192.88.168.50; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(6806004)(19580395003)(50466002)(62966003)(229853001)(19580405001)(77156002)(68736005)(77096005)(85426001)(50226001)(2351001)(106466001)(105606002)(107886002)(5001960100002)(48376002)(50986999)(76176999)(189998001)(110136002)(97736004)(5001920100001)(5001830100001)(81156007)(5007970100001)(4001540100001)(11100500001)(104016003)(47776003)(2950100001)(86362001)(64706001)(87936001)(5003940100001)(36756003)(33646002)(46102003)(92566002)(5001860100001)(4001430100001); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR03MB1380; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; MIME-Version: 1.0 X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1380; 2:OVm9BvoP2sNRy0pvZnS1GjAX1XobNujiKV+mpVJ/0G/qtavv05O2lsn72vvfa0KFgErNyASn1fZt1LHcfOUe7EwbuQZgCkiOx4JiM+72+Ifo8Yqm/FLQKMneQtjilJ7QiWSz8BH+V9p11m4+bxbXEXHeFdCisvMYCr3Gbc8CV0g=; 3:FHM/Qcdjk6SLzHOsHGfeaEjXxwagpPpGJxqoub9kqsRvb4aJU7wj9dzCrz62sGvpuXx4yHXkDgFRE2OQIGdF1RMLiGv8NeOpMjLhwZwnagWQ86bb72G1XK0EW1utmEHAQSrJLhf+Ar+FivdffEkUmXB0DJRTnT5D6HwbE9dt+8a398pvMM9Le0mE2b70mXiYnmgSbtS+oJYftgsGRrRgXM8hB7IUAAE1INVyo8An+sM=; 25:PKsrv9MNlHVedCOqOD9LA2/PgBbcrxKYBIvtDY89NbTUMjJeXpexpvt0tKygXAU2Ygtc5s37Sw37VN9W49M2axoqW4PCyddGA2evmEiinaKXVX4GIZ9NyxYb1iCQ+7bLwZz5lZPoX8X8LoVPGuSIk1KZpZ71fG/LFB1UfRJiAIMsTJll5hvI3w3RLvW5e1NXJU98GSfuAqwhvFZzSkpUkQ8TAXP2kERtax4MHJd/sRNmHhsuZoDleNKwRQonGjV/ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1380; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1380; 20:Qqo5Y3hGVHfCWdrL7/u8d4hg2IRswTsdWKMH+xr3SR1lsQ0GJR+b44A4q2kewe1NUmTum2eGMqf0RWSXWlaQPW6wUlodmYs/oz3Xqi4Fs/mjwJ1I4K8fIjPnsCfh/YvyzTFOJkcz7/NYenNvWmdQ/v0d5ucHuDWtaPz9C98Ex5cw3+aXP1spgAF/A9NKGof4X1QWUCEBaxZ/+GBd9ovaknyEl0+eqHtNg9zkET/zj9wZi6oRKhh96k7oIqoR+nlp1bXL1vxtgADyRoLoF1p6u2KeQYgdN5+aDK5yrIGciyreivf++swe0crTcCWQT8MUhEm/bKw3CFA49SUG7hmHGWqcFnS01NlCUf2OYrDlWUg=; 4:ttpt5iTTTKGj5Z86/bo7WfjRxe99SLq7ifiICIrDgOTyuM8Zm1myumtB0UgY5I26iwy4KVjxdgbZDglg+gIFnll+PhIelxdJn12rq1CxNXZ2wWwMID7nlO+Fhp0qcJHfdIL51NC11SFv5+kYDWGB0aPcumuSmotwSlVwUM4Ta14eFlw3PHYmuMVGxh0yR69TSlf2hJHvLvldftZOF0VcuRuux/tsPaBhNnU+hl9J/dh9TX+3Xv0xn7ZOQaZdckMIkdaXLrSEvQSwS9rtyj7JCfRzzMbah567WZ3p5VySm6ARw9/D1FX374axRK4UTrzF X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(8121501046)(3002001); SRVR:BLUPR03MB1380; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB1380; X-Forefront-PRVS: 0699FCD394 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR03MB1380; 23:WK6Abxsqn6tdiLQSowonFqdWTxD9yvpA/y/XOptZJ?= =?us-ascii?Q?vTmROyi9I2Unt7edJFFU+16P8v+aVE5aLvMLtm9CEPY7FUOJUUHyQGXVd1Xv?= =?us-ascii?Q?8gL0HNoirRVHG70zZ3FsLdgV4VhJaI8ntvWMCAlJfZ2i6kxhNRJE6KuNnxEP?= =?us-ascii?Q?6yf76hCjTHZ3NFvTELEBluxED3/CnBvsdmw4iiJsYqYNpytwe6A+EeQ7+ZK6?= =?us-ascii?Q?rEb630qB5z4RQk7SiWODm+PVwqBZsHLtxygjfY9H6Fn36DrTH9/hO/s3kgno?= =?us-ascii?Q?Yt6RbmYXnrri1X4sDVRMzUUma4LBB/i6ssZfuWL0w8uclPozBS3p2gST0PSi?= =?us-ascii?Q?HR9uyl3ja7oknezUY6kH4i0QpXL/qGTAsLabI1DZlrmpNDwLv8J5IQHudO4U?= =?us-ascii?Q?EdyY0nHMZt3on2ee4c/XmKJZJ+wRgBKchRG+BZkkKhxO8HtzyF5IHezYFEgV?= =?us-ascii?Q?vl/CeTHDFW7AZQnVFHTv8d9nllVDecmp7OIRCnXWIW2rWVtMKA3Ud/7HHsFH?= =?us-ascii?Q?F9pG4Ux0txPwje6I2v4bD+dZd10kYdAo2Mfwtq2O8O+ZjIcGjpt3pLeTnsAe?= =?us-ascii?Q?klCZUou0B1Wgzd3/XQb6wR2dVbW+5g25SqJlq+d1rnIlI4031KJmgQXusi3y?= =?us-ascii?Q?6BIKl7qIqgdMSxCtZI3ORovA9st7fDHBd4nB/wn5NRMko1KaZbkbuFojJ1IW?= =?us-ascii?Q?XnHgU57WVWx7wbBIIYty5bMmpUcxForjFvgIs32FaBPybuFuNJah5QLbYtNZ?= =?us-ascii?Q?13fen7rsyqsYtZ++zBuR3jUY88VmNEXpZONSbNg8rM8SxRO31ql/0SNu1xTr?= =?us-ascii?Q?+capkoaGrLYexpp24MwiFrEUsFB1KfBZ9xBUSZ37avAMrz69ye25q+H6e4Xw?= =?us-ascii?Q?t3U6CiqSTy2hLxIeBZYfwk2J+i3JkVwxedHGM8LwTHlYR4fbAQSsh65pcpL1?= =?us-ascii?Q?Wtlib2q8Ehd8GmJO8gcGPH10pjorbCixvXsDLdyA/CkurqtBhIAhuoq+bpcX?= =?us-ascii?Q?y/SkpJh3CMMjKLm5KA2rgg1u0/FiCuAUiGDYXNsdu1x4PKga2jTjwlazg/on?= =?us-ascii?Q?8KDMuIRT5Oqa5DpF5JDf23lizncYI1ljoITZmA1Cg8RtcCjxJ1+7WPaXnUwE?= =?us-ascii?Q?Dxfp4J+ttbU5GdJtuRIDgNdaWUIWeMl2tO/Uin31It0sDdk7Dtsd31XSA+TY?= =?us-ascii?Q?NaySZyfiP5aL7Gt3ET11up4xZHrOqpAtP9y/vmcOUKpjdrdA3GU8rEe72RK+?= =?us-ascii?Q?eEHi2aNoujA5jv1vV6wzn219/9ohgz5+KGjn5vCwp1vflBQxY2MPcPIxz0wB?= =?us-ascii?B?QT09?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1380; 5:7wMcx/TB1MU+uLebm0BQ3YIC4AD3aTd+vVg5SqflgkV4z3uCATflt5Crrt1QZ7Frw+LIvKlLz/eqDiQ6RJgcA/HVWqrBHy7mPkLOylOgG2LnAt6uNIGOXSL/rUvTzWPOATEXwUC2JugIlmpdabBtUg==; 24:DPjoJ3z0CHOoa1zmV1c5a0Ojun2ZILHHOpjnIWEbKOCf6E2mDYaCQiYU0BP1rtRHe+HI1Ns3xiIlWdewy19PCzv2fpPPe6Xaw+QknIxFdUE=; 20:vugZkE+W6H2eAD9wbwR8cGtK2wboDvxvXtFHIvseKvmqrfT++L63Kmons20KMhPUuU2eFi2tSSnNE6xT6EJaYg== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2015 16:53:28.4226 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1380 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We should check for negative values returned by platform_get_irq(). Signed-off-by: Fabio Estevam --- drivers/input/touchscreen/imx6ul_tsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index 0a96b76..4957d8b 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -416,7 +416,7 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) } adc_irq = platform_get_irq(pdev, 1); - if (adc_irq <= 0) { + if (adc_irq < 0) { dev_err(&pdev->dev, "no adc irq resource?\n"); return adc_irq; }