From patchwork Wed May 25 11:40:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Just X-Patchwork-Id: 9135933 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A68046075C for ; Wed, 25 May 2016 17:42:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C4561FFC9 for ; Wed, 25 May 2016 17:42:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 913B5282BB; Wed, 25 May 2016 17:42:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, DATE_IN_PAST_06_12, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 35A701FFC9 for ; Wed, 25 May 2016 17:42:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932753AbcEYRly (ORCPT ); Wed, 25 May 2016 13:41:54 -0400 Received: from mail-ig0-f195.google.com ([209.85.213.195]:34734 "EHLO mail-ig0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932622AbcEYRlw (ORCPT ); Wed, 25 May 2016 13:41:52 -0400 Received: by mail-ig0-f195.google.com with SMTP id lp2so5873802igb.1 for ; Wed, 25 May 2016 10:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qkA2Xu8QxIuJo2l70TuTfmDpZTVDazpfWPHFRwNKphc=; b=m4XKZu2rPdHUrUUYGJvCjYudOGnXifyGPzZ66ONQMFu7Olwbn6mQ6IKf/aNVAOdJNJ 548XbbLZAn8XtaDhMYUMhmwTN4JxMvqOAdEEUOI8y1P5aigHFA6TDd8kEiLR4bD91Gy0 BT2x7TRVPfo1KvPWj/KW35eEQyThh14k9vJOiMo52yGaiC5nUdoHIloZWKZnnrXE5ocR Za5oYTEOuDeJan+3EGCS8kFmBJH55jAblONExra5F82Qsp22zKN6rfA3H6M+68gubynj LX8k0Rc3rwgF26oBEtP4jcya/dWt48KW4chWOPQD6S0DKArmQ+Z6zV+AWwRdxeXAoy6g d/ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qkA2Xu8QxIuJo2l70TuTfmDpZTVDazpfWPHFRwNKphc=; b=LPDViP7bRh3elpsPvTuHQO2oXieGbzSbG15yfaiVU4p5uvbIQmvY+U5blXSxDChj7s 7gOZN6+c5H1pZcjoHr63/+Isbg0Sr6pNqD1Aoju5jn+r40zI7gGbpD50nHb+5XG83rD6 CHNrkycRDec8/kz/L4qQJtv5MEggrhmeWzMspkcJOoo22UITQIUF51MZQPbqlBM1Irsz R5m+++kaJO+Sdz4Ix4+Q37HSP3Tga7W+xxp890RU4zBpG0p8M13j9NdIRiUDSmgAamh4 NzbtQNkHHD2YGuUJLnX2CJzkrIBO3fpb0xKvixbBgXfDs2YX4qRgY0WM0iw4qv+t2+7Q jssA== X-Gm-Message-State: ALyK8tIEuxcG4XbXIrLviBR+CaakyqZEd85WGLe6J7yjVF9XEHWJNNdQawAmAY9AhhF8dg== X-Received: by 10.50.85.14 with SMTP id d14mr5146107igz.31.1464198111291; Wed, 25 May 2016 10:41:51 -0700 (PDT) Received: from arch_usb.localdomain (S0106c0c1c0256baf.ed.shawcable.net. [70.74.127.58]) by smtp.gmail.com with ESMTPSA id q15sm3140015iod.6.2016.05.25.10.41.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 May 2016 10:41:50 -0700 (PDT) From: Stephen Just To: linux-input@vger.kernel.org, Dmitry Torokhov , Benjamin Tissoires Cc: Stephen Just , Bastien Nocera , Peter Hutterer Subject: [PATCH v3 1/2] Input - surface3_spi: Prepare to add support for Surface Pen Date: Wed, 25 May 2016 05:40:04 -0600 Message-Id: <1464176406-9917-2-git-send-email-stephenjust@gmail.com> X-Mailer: git-send-email 2.8.2 In-Reply-To: <1464176406-9917-1-git-send-email-stephenjust@gmail.com> References: <1464176406-9917-1-git-send-email-stephenjust@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Surface Pens can be supported by handling a second report type. Prepare for this change. Signed-off-by: Stephen Just --- v1 -> v3: No change drivers/input/touchscreen/surface3_spi.c | 38 +++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c index 58631d1..204a162 100644 --- a/drivers/input/touchscreen/surface3_spi.c +++ b/drivers/input/touchscreen/surface3_spi.c @@ -27,6 +27,8 @@ #define SURFACE3_PACKET_SIZE 264 +#define SURFACE3_REPORT_TOUCH 0xd2 + struct surface3_ts_data { struct spi_device *spi; struct gpio_desc *gpiod_rst[2]; @@ -84,19 +86,10 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data, } } -static void surface3_spi_process(struct surface3_ts_data *ts_data) +static void surface3_spi_process_touch(struct surface3_ts_data *ts_data, u8 *data) { - const char header[] = {0xff, 0xff, 0xff, 0xff, 0xa5, 0x5a, 0xe7, 0x7e, - 0x01, 0xd2, 0x00, 0x80, 0x01, 0x03, 0x03}; - u8 *data = ts_data->rd_buf; u16 timestamp; unsigned int i; - - if (memcmp(header, data, sizeof(header))) - dev_err(&ts_data->spi->dev, - "%s header error: %*ph, ignoring...\n", - __func__, (int)sizeof(header), data); - timestamp = get_unaligned_le16(&data[15]); for (i = 0; i < 13; i++) { @@ -121,6 +114,25 @@ static void surface3_spi_process(struct surface3_ts_data *ts_data) input_sync(ts_data->input_dev); } +static void surface3_spi_process(struct surface3_ts_data *ts_data) +{ + const char header[] = {0xff, 0xff, 0xff, 0xff, 0xa5, 0x5a, 0xe7, 0x7e, 0x01}; + + u8 *data = ts_data->rd_buf; + + if (memcmp(header, data, sizeof(header))) + dev_err(&ts_data->spi->dev, + "%s header error: %*ph, ignoring...\n", + __func__, (int)sizeof(header), data); + + if (data[9] == SURFACE3_REPORT_TOUCH) + surface3_spi_process_touch(ts_data, data); + else + dev_err(&ts_data->spi->dev, + "%s unknown packet type: %x, ignoring...\n", + __func__, data[9]); +} + static irqreturn_t surface3_spi_irq_handler(int irq, void *dev_id) { struct surface3_ts_data *data = dev_id; @@ -176,7 +188,7 @@ static int surface3_spi_get_gpio_config(struct surface3_ts_data *data) return 0; } -static int surface3_spi_create_input(struct surface3_ts_data *data) +static int surface3_spi_create_touch_input(struct surface3_ts_data *data) { struct input_dev *input; int error; @@ -199,7 +211,7 @@ static int surface3_spi_create_input(struct surface3_ts_data *data) input->phys = "input/ts"; input->id.bustype = BUS_SPI; input->id.vendor = 0x045e; /* Microsoft */ - input->id.product = 0x0000; + input->id.product = 0x0001; input->id.version = 0x0000; error = input_register_device(input); @@ -239,7 +251,7 @@ static int surface3_spi_probe(struct spi_device *spi) surface3_spi_power(data, false); surface3_spi_power(data, true); - error = surface3_spi_create_input(data); + error = surface3_spi_create_touch_input(data); if (error) return error;