| Message ID | 1466158929-19524-3-git-send-email-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Neil, On Fri, Jun 17, 2016 at 12:22:06PM +0200, Neil Armstrong wrote: > In order to support pwrkey for Qualcomm MDM9615 SoC, add support > for the pm8018 pwrkey in pmic8xxx-pwrkey. Why do we need a new compat string if IP block is compatible with 8921? > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt | 1 + > drivers/input/misc/pmic8xxx-pwrkey.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt b/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt > index 588536c..9e530e2 100644 > --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt > +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt > @@ -8,6 +8,7 @@ PROPERTIES > Definition: must be one of: > "qcom,pm8058-pwrkey" > "qcom,pm8921-pwrkey" > + "qcom,pm8018-pwrkey" > > - reg: > Usage: required > diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c > index 67aab86..f6f9b87 100644 > --- a/drivers/input/misc/pmic8xxx-pwrkey.c > +++ b/drivers/input/misc/pmic8xxx-pwrkey.c > @@ -446,6 +446,7 @@ static int pmic8xxx_pwrkey_remove(struct platform_device *pdev) > } > > static const struct of_device_id pm8xxx_pwr_key_id_table[] = { > + { .compatible = "qcom,pm8018-pwrkey", .data = &pm8921_pwrkey_shutdown }, > { .compatible = "qcom,pm8058-pwrkey", .data = &pm8058_pwrkey_shutdown }, > { .compatible = "qcom,pm8921-pwrkey", .data = &pm8921_pwrkey_shutdown }, > { } > -- > 1.9.1 > Thanks.
On Fri 17 Jun 03:22 PDT 2016, Neil Armstrong wrote: > In order to support pwrkey for Qualcomm MDM9615 SoC, add support > for the pm8018 pwrkey in pmic8xxx-pwrkey. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 21, 2016 at 10:25 PM, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > On Fri 17 Jun 03:22 PDT 2016, Neil Armstrong wrote: > >> In order to support pwrkey for Qualcomm MDM9615 SoC, add support >> for the pm8018 pwrkey in pmic8xxx-pwrkey. >> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> But why? What does this new compat string gives us if the behavior is exactly the same as 8921? Thanks.
diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt b/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt index 588536c..9e530e2 100644 --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt @@ -8,6 +8,7 @@ PROPERTIES Definition: must be one of: "qcom,pm8058-pwrkey" "qcom,pm8921-pwrkey" + "qcom,pm8018-pwrkey" - reg: Usage: required diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c index 67aab86..f6f9b87 100644 --- a/drivers/input/misc/pmic8xxx-pwrkey.c +++ b/drivers/input/misc/pmic8xxx-pwrkey.c @@ -446,6 +446,7 @@ static int pmic8xxx_pwrkey_remove(struct platform_device *pdev) } static const struct of_device_id pm8xxx_pwr_key_id_table[] = { + { .compatible = "qcom,pm8018-pwrkey", .data = &pm8921_pwrkey_shutdown }, { .compatible = "qcom,pm8058-pwrkey", .data = &pm8058_pwrkey_shutdown }, { .compatible = "qcom,pm8921-pwrkey", .data = &pm8921_pwrkey_shutdown }, { }
In order to support pwrkey for Qualcomm MDM9615 SoC, add support for the pm8018 pwrkey in pmic8xxx-pwrkey. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt | 1 + drivers/input/misc/pmic8xxx-pwrkey.c | 1 + 2 files changed, 2 insertions(+)