From patchwork Tue Aug 16 02:59:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 9282517 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DAC7D600CB for ; Tue, 16 Aug 2016 03:16:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFABA28C98 for ; Tue, 16 Aug 2016 03:16:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C42EF28CA1; Tue, 16 Aug 2016 03:16:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4023B28C98 for ; Tue, 16 Aug 2016 03:16:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752905AbcHPDQR (ORCPT ); Mon, 15 Aug 2016 23:16:17 -0400 Received: from condef005-v.nifty.com ([210.131.4.242]:50817 "EHLO condef005-v.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbcHPDQQ (ORCPT ); Mon, 15 Aug 2016 23:16:16 -0400 X-Greylist: delayed 549 seconds by postgrey-1.27 at vger.kernel.org; Mon, 15 Aug 2016 23:16:16 EDT Received: from conuserg-08.nifty.com ([10.26.8.71])by condef005-v.nifty.com with ESMTP id u7G30iY9010923 for ; Tue, 16 Aug 2016 12:00:44 +0900 Received: from grover.sesame (FL1-119-242-215-193.osk.mesh.ad.jp [119.242.215.193]) (authenticated) by conuserg-08.nifty.com with ESMTP id u7G2xN2D015405; Tue, 16 Aug 2016 12:00:09 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com u7G2xN2D015405 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1471316410; bh=GYyELQ7f/Om46Xcz24wARm6Lm03H7kpq2PprSyFTU2E=; h=From:To:Cc:Subject:Date:From; b=qmKSqVl5/ub+ft3UhPkjX5kZInTk5jAhVzAS9lCaLqsRDOIxsodj+5q1f2YSdzgpp cjaZuLr6GTMp04V/KOq72z7mptrQIJMDjC4qrQkQZwNadNqI2Qv7Gezt2qj6Y5f3bC wLXiwiR83Kx88zoPuQAfiIkDIOBFO55zYD+1/Vp8v2Dv8OmzQ8SaGDcFyeUxFT93EJ zW22rHn4l451jWq0L65IkdsCbLZrGKREj4WYfLUd0NEgz7eYX4zZvaPTFEEZkQ+uJm NB9BBN8zens0XzbOhzk9Xjp84jbt0zDBoEdM2d6wUMwA1PAIdMzuG7uBy8wYwG8ud7 puPH+KR7HmYtg== X-Nifty-SrcIP: [119.242.215.193] From: Masahiro Yamada To: linux-input@vger.kernel.org, Dmitry Torokhov Cc: Masahiro Yamada , Thierry Reding , linux-kernel@vger.kernel.org, Stephen Warren , Rakesh Iyer , Laxman Dewangan , linux-tegra@vger.kernel.org, Alexandre Courbot Subject: [PATCH] Input: tegra-kbc: fix inverted reset logic Date: Tue, 16 Aug 2016 11:59:23 +0900 Message-Id: <1471316363-19378-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") accidentally converted _deassert to _assert, so there is no code to wake up this hardware. Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") Signed-off-by: Masahiro Yamada Acked-by: Thierry Reding Acked-by: Laxman Dewangan --- drivers/input/keyboard/tegra-kbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c index 7d61439..0c07e10 100644 --- a/drivers/input/keyboard/tegra-kbc.c +++ b/drivers/input/keyboard/tegra-kbc.c @@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc) /* Reset the KBC controller to clear all previous status.*/ reset_control_assert(kbc->rst); udelay(100); - reset_control_assert(kbc->rst); + reset_control_deassert(kbc->rst); udelay(100); tegra_kbc_config_pins(kbc);