| Message ID | 1471793450-24245-1-git-send-email-weiyj.lk@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, 2016-08-21 at 15:30 +0000, Wei Yongjun wrote: > Use kzalloc rather than kmalloc followed by memset with 0. > > Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > --- > drivers/hid/intel-ish-hid/ishtp/client-buffers.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c > b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c > index 3f5ce5e..b9b917d 100644 > --- a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c > +++ b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c > @@ -73,11 +73,10 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl) > for (j = 0; j < cl->tx_ring_size; ++j) { > struct ishtp_cl_tx_ring *tx_buf; > > - tx_buf = kmalloc(sizeof(struct ishtp_cl_tx_ring), > GFP_KERNEL); > + tx_buf = kzalloc(sizeof(struct ishtp_cl_tx_ring), > GFP_KERNEL); > if (!tx_buf) > goto out; > > - memset(tx_buf, 0, sizeof(struct ishtp_cl_tx_ring)); > tx_buf->send_buf.data = kmalloc(len, GFP_KERNEL); > if (!tx_buf->send_buf.data) { > kfree(tx_buf); > > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c index 3f5ce5e..b9b917d 100644 --- a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c +++ b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c @@ -73,11 +73,10 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl) for (j = 0; j < cl->tx_ring_size; ++j) { struct ishtp_cl_tx_ring *tx_buf; - tx_buf = kmalloc(sizeof(struct ishtp_cl_tx_ring), GFP_KERNEL); + tx_buf = kzalloc(sizeof(struct ishtp_cl_tx_ring), GFP_KERNEL); if (!tx_buf) goto out; - memset(tx_buf, 0, sizeof(struct ishtp_cl_tx_ring)); tx_buf->send_buf.data = kmalloc(len, GFP_KERNEL); if (!tx_buf->send_buf.data) { kfree(tx_buf);
Use kzalloc rather than kmalloc followed by memset with 0. Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com> --- drivers/hid/intel-ish-hid/ishtp/client-buffers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html