| Message ID | 1472632661-32159-1-git-send-email-baoyou.xie@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Wednesday, August 31, 2016 4:37:41 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > Acked-by: Arnd Bergmann <arnd@arndb.de> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Aug 31, 2016 at 11:58:50AM +0200, Arnd Bergmann wrote: > On Wednesday, August 31, 2016 4:37:41 PM CEST Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > > drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes] > > > > In fact, this function is only used in the file in which it is > > declared and don't need a declaration, but can be made static. > > So this patch marks it 'static'. > > > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > > > > Acked-by: Arnd Bergmann <arnd@arndb.de> Applied, thank you.
diff --git a/drivers/input/mouse/focaltech.c b/drivers/input/mouse/focaltech.c index c8c6a8c..d3ca02a 100644 --- a/drivers/input/mouse/focaltech.c +++ b/drivers/input/mouse/focaltech.c @@ -390,7 +390,8 @@ static int focaltech_read_size(struct psmouse *psmouse) return 0; } -void focaltech_set_resolution(struct psmouse *psmouse, unsigned int resolution) +static void +focaltech_set_resolution(struct psmouse *psmouse, unsigned int resolution) { /* not supported yet */ }
We get 1 warning when building kernel with W=1: drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this patch marks it 'static'. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/input/mouse/focaltech.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)