diff mbox

Input: Driver drv260x.c - fix bug of adding wrong device parent

Message ID 1481578627-56391-1-git-send-email-jkwang@google.com (mailing list archive)
State Accepted
Headers show

Commit Message

Jingkui Wang Dec. 12, 2016, 9:37 p.m. UTC
Fix the bug of adding wrong parent to the input_dev created by the
driver. The bug will be triggered if rmmod is called for this driver
module.

Signed-off-by: Jingkui Wang <jkwang@google.com>
---
 drivers/input/misc/drv260x.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Dmitry Torokhov Dec. 12, 2016, 10:05 p.m. UTC | #1
On Mon, Dec 12, 2016 at 01:37:07PM -0800, Jingkui Wang wrote:
> Fix the bug of adding wrong parent to the input_dev created by the
> driver. The bug will be triggered if rmmod is called for this driver
> module.
> 
> Signed-off-by: Jingkui Wang <jkwang@google.com>

Applied and marked for stable, thank you.

> ---
>  drivers/input/misc/drv260x.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
> index 4f448ba..885c140 100644
> --- a/drivers/input/misc/drv260x.c
> +++ b/drivers/input/misc/drv260x.c
> @@ -565,7 +565,6 @@ static int drv260x_probe(struct i2c_client *client,
>  	}
>  
>  	haptics->input_dev->name = "drv260x:haptics";
> -	haptics->input_dev->dev.parent = client->dev.parent;
>  	haptics->input_dev->close = drv260x_close;
>  	input_set_drvdata(haptics->input_dev, haptics);
>  	input_set_capability(haptics->input_dev, EV_FF, FF_RUMBLE);
> -- 
> 2.6.6
>
diff mbox

Patch

diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
index 4f448ba..885c140 100644
--- a/drivers/input/misc/drv260x.c
+++ b/drivers/input/misc/drv260x.c
@@ -565,7 +565,6 @@  static int drv260x_probe(struct i2c_client *client,
 	}
 
 	haptics->input_dev->name = "drv260x:haptics";
-	haptics->input_dev->dev.parent = client->dev.parent;
 	haptics->input_dev->close = drv260x_close;
 	input_set_drvdata(haptics->input_dev, haptics);
 	input_set_capability(haptics->input_dev, EV_FF, FF_RUMBLE);