From patchwork Mon Dec 12 21:37:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingkui Wang X-Patchwork-Id: 9471437 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DA6CA607D3 for ; Mon, 12 Dec 2016 21:37:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB998284FE for ; Mon, 12 Dec 2016 21:37:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C047928524; Mon, 12 Dec 2016 21:37:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6BB56284FE for ; Mon, 12 Dec 2016 21:37:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672AbcLLVha (ORCPT ); Mon, 12 Dec 2016 16:37:30 -0500 Received: from mail-pg0-f51.google.com ([74.125.83.51]:33852 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751710AbcLLVh3 (ORCPT ); Mon, 12 Dec 2016 16:37:29 -0500 Received: by mail-pg0-f51.google.com with SMTP id x23so39457857pgx.1 for ; Mon, 12 Dec 2016 13:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=fLImJI8tVxgO5pLHfv3mzJRDc+kIp/aB6T5+CCHsDtU=; b=oAV/YZG0cwbfGIoQhCoBNhF0h6CWdk0tL9OwFNJHLMIIg3rgETAfJJJG6ciboP8IYf e+Xv0Tz6ZY3SIVysD7QIdxHms9oKBHNGQtS17Tr31cU93KFGI/XzaPtJteeTi99WFWeF LFOoKkCFgoVYZLALmJrmziwXIpKKC5Gx4Lq1N71gnYcqrEwa1njVylJ7t6x7dpBmh8v9 CvgnkZ0MO+QoxXwayERCT/7IwNGQ3aEe/aMEclDt4xaurM88X+I5DntQBKa+VGsRXaov Uydbe66ueZe8BE7ujokP4h7VyQJijPtoo5ie50ZgTZnaGOLDfxBWl4MclW7mqxSV/yNu myag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fLImJI8tVxgO5pLHfv3mzJRDc+kIp/aB6T5+CCHsDtU=; b=Snx1FIP7cFi2TMWRKQmG6C2MaTaqLaCWZxVjUEWj56NZZv+XzEgnq7ASmCcr9MQLkT lulr5qQXuBxc9dXttIP7CdUWYmnr7gL4uSJT4EkWugywS/3/gPO+BVOgtGcFUQ7+UQez QMaw9P7kx2S9ia2ss0X2KgRL6XukUlCs6two2tRUOWIxc6PIVM/PMJkvWTg6vSlLojtq 9QJM3RezqSZNdhCfDVf4bhFB5iuj316CNvg1M2rwj2eg+abdIxS9DdftFMJvDUQNK+XS rQGvcGllhUmgEdnkQ8wi1LnGGH3Xh87WWvqUfti6TCtydN/cJKdB51jFVHrCNAaKdUEA k7tg== X-Gm-Message-State: AKaTC01cgBrnAZWZvlsAMDdKWC0nEN1Y4sNX76eatPGPY4jFaAvAb0SlIO6mWEUg3IQwiTVY X-Received: by 10.99.227.81 with SMTP id o17mr171864133pgj.69.1481578648721; Mon, 12 Dec 2016 13:37:28 -0800 (PST) Received: from jkwang0.mtv.corp.google.com ([2620:0:1000:1301:3556:88dc:7349:2ca3]) by smtp.gmail.com with ESMTPSA id u78sm72161933pfa.53.2016.12.12.13.37.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Dec 2016 13:37:28 -0800 (PST) From: Jingkui Wang To: linux-input@vger.kernel.org Cc: dmitry.torokhov@gmail.com, Dan Murphy , Jingkui Wang Subject: [PATCH] Input: Driver drv260x.c - fix bug of adding wrong device parent Date: Mon, 12 Dec 2016 13:37:07 -0800 Message-Id: <1481578627-56391-1-git-send-email-jkwang@google.com> X-Mailer: git-send-email 2.6.6 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix the bug of adding wrong parent to the input_dev created by the driver. The bug will be triggered if rmmod is called for this driver module. Signed-off-by: Jingkui Wang --- drivers/input/misc/drv260x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c index 4f448ba..885c140 100644 --- a/drivers/input/misc/drv260x.c +++ b/drivers/input/misc/drv260x.c @@ -565,7 +565,6 @@ static int drv260x_probe(struct i2c_client *client, } haptics->input_dev->name = "drv260x:haptics"; - haptics->input_dev->dev.parent = client->dev.parent; haptics->input_dev->close = drv260x_close; input_set_drvdata(haptics->input_dev, haptics); input_set_capability(haptics->input_dev, EV_FF, FF_RUMBLE);