From patchwork Tue Jan 3 12:45:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donohue X-Patchwork-Id: 9494819 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CA92E606A7 for ; Tue, 3 Jan 2017 12:51:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B483026CFF for ; Tue, 3 Jan 2017 12:51:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A99BE26E16; Tue, 3 Jan 2017 12:51:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9FF0326CFF for ; Tue, 3 Jan 2017 12:51:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933118AbdACMvP (ORCPT ); Tue, 3 Jan 2017 07:51:15 -0500 Received: from Lepton.TopQuark.net ([168.235.66.66]:45831 "EHLO Mail2.TopQuark.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932857AbdACMvO (ORCPT ); Tue, 3 Jan 2017 07:51:14 -0500 X-Greylist: delayed 310 seconds by postgrey-1.27 at vger.kernel.org; Tue, 03 Jan 2017 07:51:14 EST Received: from Mail1.TopQuark.net (pool-108-48-201-133.washdc.fios.verizon.net [108.48.201.133]) by Mail2.TopQuark.net (Postfix) with ESMTP id 15A93F6000C; Tue, 3 Jan 2017 07:46:02 -0500 (EST) Received: from Mail1.TopQuark.net (unknown [127.0.0.1]) by Mail1.TopQuark.net (Postfix) with ESMTP id 2598D27EE0BE; Tue, 3 Jan 2017 07:46:02 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=PaulSD.com; h=from:to:cc :subject:date:message-id; s=mail; bh=El02pg/40GIRXab8GR7VIfNefIA =; b=nCLRRvWpKIhugAtwvZhZejVdUvqzV911AJAP9C2wvHvWaoc4b3bmSn0DlF6 pH+y3vjGVS8A6b9eF4H+RhKNxAheZjry71gRnTqGZpsVY9b5WXAa8hSOgtXWSeik D5ab5V9gLSxdvyZOKVAuX2BSYEOGoWOJk9NqyqYcgmMYZtXc= Received: by Mail1.TopQuark.net (Postfix, from userid 1000) id BEF0527EE25B; Tue, 3 Jan 2017 07:45:59 -0500 (EST) From: Paul Donohue To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Paul Donohue Subject: [PATCH] Input: ALPS - fix TrackStick Y axis handling for SS5 hardware Date: Tue, 3 Jan 2017 07:45:29 -0500 Message-Id: <1483447529-13565-1-git-send-email-linux-kernel@PaulSD.com> X-Mailer: git-send-email 2.7.4 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A minus character was lost in commit 23fce365, causing the Y axis to be inverted for SS5 TrackStick events. (Pushing the TrackStick up caused the pointer to move down, and vice versa.) Restore the lost minus. Signed-off-by: Paul Donohue --- drivers/input/mouse/alps.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/alps.h b/drivers/input/mouse/alps.h index cde6f4b..6d279aa 100644 --- a/drivers/input/mouse/alps.h +++ b/drivers/input/mouse/alps.h @@ -114,7 +114,7 @@ enum SS4_PACKET_ID { (_b[1] & 0x7F) \ ) -#define SS4_TS_Y_V2(_b) (s8)( \ +#define SS4_TS_Y_V2(_b) -(s8)( \ ((_b[3] & 0x01) << 7) | \ (_b[2] & 0x7F) \ )