From patchwork Wed Jan 18 17:46:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 9524439 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 91DA260113 for ; Wed, 18 Jan 2017 17:51:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 835D82863D for ; Wed, 18 Jan 2017 17:51:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 785D32864C; Wed, 18 Jan 2017 17:51:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DEA42863D for ; Wed, 18 Jan 2017 17:51:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753552AbdARRvD (ORCPT ); Wed, 18 Jan 2017 12:51:03 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:58954 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753318AbdARRsz (ORCPT ); Wed, 18 Jan 2017 12:48:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=References:In-Reply-To:Message-Id:Date:Subject: Cc:To:From; bh=QGgQ41ba5wNE4w9Rdv5R/IUT9AX3WT0yDqAXAgkPJ/A=; b=V0FzNLUoRsLjjr Wr/YCVcwgI0SrNfrRlbCUQ3a92vD8PDWpgCLb3KkhYheFzu/KzwBvSb98Hzsue4mQNbVtlF/+aojX Z1E0OZmMb9sGenrGIOnd+pmSFt5auCx5kwOZwvaFone2gO5XpHvlSSEZgdPLxGZ35w+9LuU2RSpd+ LAq7lC+Qttz7cy05YKGhduH6FgF5FRtFgth2AjMWlkkIoIsIlmgqPqRbn5jwjvFwUvSJPBvnX802o //wpZ6606cRJigGNIdcGJDJr7teWZ+rEeWPGUqngs/pq5JM5E0j0Tu16KoUaj4n8WMorhM4Ic5vE5 NCu538fEQr0Xi+ymg0Cg==; Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:45204 helo=localhost) by bh-25.webhostbox.net with esmtpa (Exim 4.86_1) (envelope-from ) id 1cTuLf-001m3u-KR; Wed, 18 Jan 2017 17:48:39 +0000 From: Guenter Roeck To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck Subject: [PATCH 24/33] Input: ar1021_i2c - Drop unnecessary call to i2c_set_clientdata and other changes Date: Wed, 18 Jan 2017 09:46:45 -0800 Message-Id: <1484761614-12225-25-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1484761614-12225-1-git-send-email-linux@roeck-us.net> References: <1484761614-12225-1-git-send-email-linux@roeck-us.net> X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no call to i2c_get_clientdata() or dev_get_drvdata(). Drop the unnecessary call to i2c_set_clientdata(). This conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches - Replace 'goto l; ... l: return e;' with 'return e;' - Drop i2c_set_clientdata() Signed-off-by: Guenter Roeck --- drivers/input/touchscreen/ar1021_i2c.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c index 71b5a634cf6d..b289eca2b797 100644 --- a/drivers/input/touchscreen/ar1021_i2c.c +++ b/drivers/input/touchscreen/ar1021_i2c.c @@ -35,11 +35,11 @@ static irqreturn_t ar1021_i2c_irq(int irq, void *dev_id) retval = i2c_master_recv(ar1021->client, ar1021->data, sizeof(ar1021->data)); if (retval != sizeof(ar1021->data)) - goto out; + return IRQ_HANDLED; /* sync bit set ? */ if ((data[0] & 0x80) == 0) - goto out; + return IRQ_HANDLED; button = data[0] & BIT(0); x = ((data[2] & 0x1f) << 7) | (data[1] & 0x7f); @@ -50,7 +50,6 @@ static irqreturn_t ar1021_i2c_irq(int irq, void *dev_id) input_report_key(input, BTN_TOUCH, button); input_sync(input); -out: return IRQ_HANDLED; } @@ -127,7 +126,6 @@ static int ar1021_i2c_probe(struct i2c_client *client, return error; } - i2c_set_clientdata(client, ar1021); return 0; }