From patchwork Wed Jan 18 17:46:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 9524495 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3CC4C6020B for ; Wed, 18 Jan 2017 17:54:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E87D28627 for ; Wed, 18 Jan 2017 17:54:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2372828629; Wed, 18 Jan 2017 17:54:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9B5A28618 for ; Wed, 18 Jan 2017 17:54:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751323AbdARRwj (ORCPT ); Wed, 18 Jan 2017 12:52:39 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:58969 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753270AbdARRsu (ORCPT ); Wed, 18 Jan 2017 12:48:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=References:In-Reply-To:Message-Id:Date:Subject: Cc:To:From; bh=w54lnYoDWUcg11xfFGXZ6dFKKPDH96D5eW40YgRjR6w=; b=PbMYSiwy4cz14N r/bQXMsK4acxlvRMfhY2sOGKI2Mq1v2dlbIA4VkY5Oxt5A4lo1ToPraFPNrcvzfLPqH1FapbNnKMi O8N+RcFc44w/NRC+k+QH7LPSrHKEcP5Lpx9aIFoTwGZ2EU+r2AWNQoI4oluZLcwkE2YlgWDSjYJBa WkEsc8wc4nq6BTPTJ6giMwV3eOGv4DbslvbaLGx2+mdzEmCZsnrau4ajHoUBVf9ahsOJFL5KB9TKS BWlyeh4JZxJk0TI75UNs+EeTr4N4xi2fgn8UWL4AJ6S/oDHmcWDcTX/QIGv5otEnpzdZ76zM4RbaX Kk2VhVZ44izj1ggyuT5A==; Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:45210 helo=localhost) by bh-25.webhostbox.net with esmtpa (Exim 4.86_1) (envelope-from ) id 1cTuLn-001mOv-SK; Wed, 18 Jan 2017 17:48:48 +0000 From: Guenter Roeck To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck Subject: [PATCH 27/33] Input: eeti_ts - Drop unnecessary error messages and other changes Date: Wed, 18 Jan 2017 09:46:48 -0800 Message-Id: <1484761614-12225-28-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1484761614-12225-1-git-send-email-linux@roeck-us.net> References: <1484761614-12225-1-git-send-email-linux@roeck-us.net> X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Error messages after memory allocation failures are unnecessary and can be dropped. This conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches - Drop unnecessary braces around conditional return statements - Drop error message after devm_kzalloc() failure - Replace 'goto l; ... l: return e;' with 'return e;' Signed-off-by: Guenter Roeck --- drivers/input/touchscreen/eeti_ts.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/eeti_ts.c b/drivers/input/touchscreen/eeti_ts.c index 09be6ced7151..de3f4a1e8416 100644 --- a/drivers/input/touchscreen/eeti_ts.c +++ b/drivers/input/touchscreen/eeti_ts.c @@ -171,10 +171,8 @@ static int eeti_ts_probe(struct i2c_client *client, */ priv = kzalloc(sizeof(*priv), GFP_KERNEL); - if (!priv) { - dev_err(&client->dev, "failed to allocate driver data\n"); - goto err0; - } + if (!priv) + return err; mutex_init(&priv->mutex); input = input_allocate_device(); @@ -243,7 +241,6 @@ static int eeti_ts_probe(struct i2c_client *client, err1: input_free_device(input); kfree(priv); -err0: return err; }