diff mbox

[1/4] input:touchscreen:ad7879-spi.c: Fix regmap flag_masks

Message ID 1487780078-18510-2-git-send-email-michael.hennerich@analog.com (mailing list archive)
State Under Review
Headers show

Commit Message

Hennerich, Michael Feb. 22, 2017, 4:14 p.m. UTC 
From: Michael Hennerich <michael.hennerich@analog.com>

Mask only applied to the top byte of the register

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
---
 drivers/input/touchscreen/ad7879-spi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dmitry Torokhov Feb. 23, 2017, 8:43 a.m. UTC | #1 
On Wed, Feb 22, 2017 at 05:14:35PM +0100, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
> 
> Mask only applied to the top byte of the register
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>

Thank you Michael, I folded it with the patch introducing regmaps.

> ---
>  drivers/input/touchscreen/ad7879-spi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c
> index f2c06b5..b995891 100644
> --- a/drivers/input/touchscreen/ad7879-spi.c
> +++ b/drivers/input/touchscreen/ad7879-spi.c
> @@ -19,8 +19,8 @@
>  
>  #define MAX_SPI_FREQ_HZ      5000000
>  
> -#define AD7879_CMD_MAGIC     0xE000
> -#define AD7879_CMD_READ      BIT(10)
> +#define AD7879_CMD_MAGIC     0xE0
> +#define AD7879_CMD_READ      BIT(2)
>  
>  static const struct regmap_config ad7879_spi_regmap_config = {
>  	.reg_bits = 16,
> -- 
> 2.7.4
>
diff mbox

Patch

diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c
index f2c06b5..b995891 100644
--- a/drivers/input/touchscreen/ad7879-spi.c
+++ b/drivers/input/touchscreen/ad7879-spi.c
@@ -19,8 +19,8 @@ 
 
 #define MAX_SPI_FREQ_HZ      5000000
 
-#define AD7879_CMD_MAGIC     0xE000
-#define AD7879_CMD_READ      BIT(10)
+#define AD7879_CMD_MAGIC     0xE0
+#define AD7879_CMD_READ      BIT(2)
 
 static const struct regmap_config ad7879_spi_regmap_config = {
 	.reg_bits = 16,