From patchwork Wed Mar 1 05:37:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Schocher X-Patchwork-Id: 9597959 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 597C160414 for ; Wed, 1 Mar 2017 09:34:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6621D284E9 for ; Wed, 1 Mar 2017 09:34:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5AB6D28518; Wed, 1 Mar 2017 09:34:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C7FFD284E9 for ; Wed, 1 Mar 2017 09:34:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751062AbdCAJeB (ORCPT ); Wed, 1 Mar 2017 04:34:01 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:50123 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbdCAJd4 (ORCPT ); Wed, 1 Mar 2017 04:33:56 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3vY4372x31z3hjfD; Wed, 1 Mar 2017 06:37:39 +0100 (CET) Received: from localhost (dynscan01.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3vY4370YHzzvkLK; Wed, 1 Mar 2017 06:37:39 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan01.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id wiy4xSjirv2R; Wed, 1 Mar 2017 06:37:38 +0100 (CET) X-Auth-Info: XE68h2/V1rbme/5itejzc9wgAF34BiEGuc3ZhEm+7Gw= Received: from mail-internal.denx.de (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) by mail.mnet-online.de (Postfix) with ESMTPA; Wed, 1 Mar 2017 06:37:38 +0100 (CET) Received: from pollux.denx.de (pollux [192.168.1.1]) by mail-internal.denx.de (Postfix) with ESMTP id C2E16180041; Wed, 1 Mar 2017 06:37:24 +0100 (CET) Received: by pollux.denx.de (Postfix, from userid 515) id 8F3F758FB; Wed, 1 Mar 2017 06:37:24 +0100 (CET) From: Heiko Schocher To: linux-input@vger.kernel.org Cc: Guan Ben , Mark Jonas , Heiko Schocher , devicetree@vger.kernel.org, Thierry Reding , linux-kernel@vger.kernel.org, Boris Brezillon , Rob Herring , Dmitry Torokhov , Manfred Schlaegl , Mark Rutland Subject: [PATCH v3] Input: pwm-beeper: support customized freq for SND_BELL Date: Wed, 1 Mar 2017 06:37:22 +0100 Message-Id: <1488346642-14351-1-git-send-email-hs@denx.de> X-Mailer: git-send-email 2.7.4 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Guan Ben extend the pwm-beeper driver to support customized frequency for SND_BELL from device tree. Signed-off-by: Guan Ben Signed-off-by: Mark Jonas [hs@denx.de: adapted to 4.10-rc7] Signed-off-by: Heiko Schocher Acked-by: Rob Herring --- Changes in v3: - add comment from David Lechner: - readd the switch statement, instead using if / then - remove check IS_ENABLED(CONFIG_OF) - remove not used node variable - change warning string from "Failed to read beeper-hz" to "'beeper-hz' not specified" - remove function pwm_beeper_init_bell_frequency() as it is to simple. - checked that device_property_read_u32() does not modify the bell_frequency, if the property "beeper_hz" is not defined. - add comment from Rob Herring: - add Acked-by from Rob Herring Rob also mentioned to remove the IS_ENABLED(CONFIG_OF) check and node variable is unused. Changes in v2: - add comment from Rob Herring: rename property name "bell-frequency" to "beeper-hz" - add comment from Dmitry Torokhov: use device_property_read_u32() instead of of_property_read_u32() - rebased against c470abd4fde40ea6a0846a2beab642a578c0b8cd Linux 4.10 Documentation/devicetree/bindings/input/pwm-beeper.txt | 3 +++ drivers/input/misc/pwm-beeper.c | 11 ++++++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.txt b/Documentation/devicetree/bindings/input/pwm-beeper.txt index be332ae..4e4e128 100644 --- a/Documentation/devicetree/bindings/input/pwm-beeper.txt +++ b/Documentation/devicetree/bindings/input/pwm-beeper.txt @@ -5,3 +5,6 @@ Registers a PWM device as beeper. Required properties: - compatible: should be "pwm-beeper" - pwms: phandle to the physical PWM device + +optional properties: +- beeper-hz: bell frequency in Hz diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c index 5f9655d..f2fcd50 100644 --- a/drivers/input/misc/pwm-beeper.c +++ b/drivers/input/misc/pwm-beeper.c @@ -27,6 +27,7 @@ struct pwm_beeper { struct pwm_device *pwm; struct work_struct work; unsigned long period; + unsigned int bell_frequency; }; #define HZ_TO_NANOSECONDS(x) (1000000000UL/(x)) @@ -60,7 +61,7 @@ static int pwm_beeper_event(struct input_dev *input, switch (code) { case SND_BELL: - value = value ? 1000 : 0; + value = value ? beeper->bell_frequency : 0; break; case SND_TONE: break; @@ -97,6 +98,7 @@ static int pwm_beeper_probe(struct platform_device *pdev) { unsigned long pwm_id = (unsigned long)dev_get_platdata(&pdev->dev); struct pwm_beeper *beeper; + unsigned int bell_frequency = 1000; int error; beeper = kzalloc(sizeof(*beeper), GFP_KERNEL); @@ -122,6 +124,13 @@ static int pwm_beeper_probe(struct platform_device *pdev) pwm_apply_args(beeper->pwm); INIT_WORK(&beeper->work, pwm_beeper_work); + error = device_property_read_u32(&pdev->dev, "beeper-hz", + &bell_frequency); + if (error < 0) + dev_dbg(&pdev->dev, "'beeper-hz' not specified, using default: %u Hz\n", + bell_frequency); + + beeper->bell_frequency = bell_frequency; beeper->input = input_allocate_device(); if (!beeper->input) {