| Message ID | 1488461278-8870-1-git-send-email-climbbb.kim@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mar 02 2017 or thereabouts, Jaejoong Kim wrote: > The cp2112 driver is working on hidraw not hiddev. So we need to use proper > hidraw name with hidraw's minor number. > > Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com> > --- Looks good to me: Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> However, this one should probably be sent in the series "[PATCH 0/2] HID: hiddev: move hiddev's minor number and refactoring" as it is a requirement for this series. I'd say resubmit this one in the v2 of the series (with my reviewed-by), so that the series is consistent and Jiri knows that this one needs to come before the rest of the series. Cheers, Benjamin > drivers/hid/hid-cp2112.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c > index b22d0f8..078026f 100644 > --- a/drivers/hid/hid-cp2112.c > +++ b/drivers/hid/hid-cp2112.c > @@ -27,6 +27,7 @@ > #include <linux/gpio.h> > #include <linux/gpio/driver.h> > #include <linux/hid.h> > +#include <linux/hidraw.h> > #include <linux/i2c.h> > #include <linux/module.h> > #include <linux/nls.h> > @@ -1297,7 +1298,8 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) > dev->adap.algo_data = dev; > dev->adap.dev.parent = &hdev->dev; > snprintf(dev->adap.name, sizeof(dev->adap.name), > - "CP2112 SMBus Bridge on hiddev%d", hdev->minor); > + "CP2112 SMBus Bridge on hidraw%d", > + ((struct hidraw *)hdev->hidraw)->minor); > dev->hwversion = buf[2]; > init_waitqueue_head(&dev->wait); > > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Benjamin 2017-03-02 23:08 GMT+09:00 Benjamin Tissoires <benjamin.tissoires@redhat.com>: > On Mar 02 2017 or thereabouts, Jaejoong Kim wrote: >> The cp2112 driver is working on hidraw not hiddev. So we need to use proper >> hidraw name with hidraw's minor number. >> >> Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com> >> --- > > Looks good to me: > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Thanks for the review. > > However, this one should probably be sent in the series "[PATCH 0/2] > HID: hiddev: move hiddev's minor number and refactoring" as it is a > requirement for this series. > > I'd say resubmit this one in the v2 of the series (with my reviewed-by), > so that the series is consistent and Jiri knows that this one needs to > come before the rest of the series. OK, I will resend v2 patchset with cp2112 Thanks, jaejoong > > Cheers, > Benjamin > > > >> drivers/hid/hid-cp2112.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c >> index b22d0f8..078026f 100644 >> --- a/drivers/hid/hid-cp2112.c >> +++ b/drivers/hid/hid-cp2112.c >> @@ -27,6 +27,7 @@ >> #include <linux/gpio.h> >> #include <linux/gpio/driver.h> >> #include <linux/hid.h> >> +#include <linux/hidraw.h> >> #include <linux/i2c.h> >> #include <linux/module.h> >> #include <linux/nls.h> >> @@ -1297,7 +1298,8 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) >> dev->adap.algo_data = dev; >> dev->adap.dev.parent = &hdev->dev; >> snprintf(dev->adap.name, sizeof(dev->adap.name), >> - "CP2112 SMBus Bridge on hiddev%d", hdev->minor); >> + "CP2112 SMBus Bridge on hidraw%d", >> + ((struct hidraw *)hdev->hidraw)->minor); >> dev->hwversion = buf[2]; >> init_waitqueue_head(&dev->wait); >> >> -- >> 2.7.4 >> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index b22d0f8..078026f 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -27,6 +27,7 @@ #include <linux/gpio.h> #include <linux/gpio/driver.h> #include <linux/hid.h> +#include <linux/hidraw.h> #include <linux/i2c.h> #include <linux/module.h> #include <linux/nls.h> @@ -1297,7 +1298,8 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) dev->adap.algo_data = dev; dev->adap.dev.parent = &hdev->dev; snprintf(dev->adap.name, sizeof(dev->adap.name), - "CP2112 SMBus Bridge on hiddev%d", hdev->minor); + "CP2112 SMBus Bridge on hidraw%d", + ((struct hidraw *)hdev->hidraw)->minor); dev->hwversion = buf[2]; init_waitqueue_head(&dev->wait);
The cp2112 driver is working on hidraw not hiddev. So we need to use proper hidraw name with hidraw's minor number. Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com> --- drivers/hid/hid-cp2112.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)