| Message ID | 1491311177-16974-1-git-send-email-martink@posteo.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Apr 04, 2017 at 03:06:17PM +0200, Martin Kepplinger wrote: > sparse says: > > sur40.c:372:40: warning: restricted __le32 degrades to integer > > the header's data is __le32 so we need to convert it before comparing. > > Signed-off-by: Martin Kepplinger <martink@posteo.de> Applied, thank you. > --- > drivers/input/touchscreen/sur40.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c > index 4c0eeca..128e5bd 100644 > --- a/drivers/input/touchscreen/sur40.c > +++ b/drivers/input/touchscreen/sur40.c > @@ -369,7 +369,7 @@ static void sur40_poll(struct input_polled_dev *polldev) > * packet ID will usually increase in the middle of a series > * instead of at the end. > */ > - if (packet_id != header->packet_id) > + if (packet_id != le32_to_cpu(header->packet_id)) > dev_dbg(sur40->dev, "packet ID mismatch\n"); > > packet_blobs = result / sizeof(struct sur40_blob); > -- > 2.1.4 >
diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c index 4c0eeca..128e5bd 100644 --- a/drivers/input/touchscreen/sur40.c +++ b/drivers/input/touchscreen/sur40.c @@ -369,7 +369,7 @@ static void sur40_poll(struct input_polled_dev *polldev) * packet ID will usually increase in the middle of a series * instead of at the end. */ - if (packet_id != header->packet_id) + if (packet_id != le32_to_cpu(header->packet_id)) dev_dbg(sur40->dev, "packet ID mismatch\n"); packet_blobs = result / sizeof(struct sur40_blob);
sparse says: sur40.c:372:40: warning: restricted __le32 degrades to integer the header's data is __le32 so we need to convert it before comparing. Signed-off-by: Martin Kepplinger <martink@posteo.de> --- drivers/input/touchscreen/sur40.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)