From patchwork Tue Mar 27 12:32:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 10309859 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EC14E600F6 for ; Tue, 27 Mar 2018 12:36:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D968A29D37 for ; Tue, 27 Mar 2018 12:36:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CE00129D3F; Tue, 27 Mar 2018 12:36:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 70A2929D37 for ; Tue, 27 Mar 2018 12:36:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752249AbeC0Mez (ORCPT ); Tue, 27 Mar 2018 08:34:55 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:53241 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbeC0Mey (ORCPT ); Tue, 27 Mar 2018 08:34:54 -0400 X-IronPort-AV: E=Sophos;i="5.48,367,1517900400"; d="scan'208";a="10562905" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 27 Mar 2018 05:34:53 -0700 Received: from eh-station.microchip.com (10.10.76.4) by chn-sv-exch02.mchp-main.com (10.10.76.38) with Microsoft SMTP Server id 14.3.352.0; Tue, 27 Mar 2018 05:34:51 -0700 From: Eugen Hristev To: , , , , , , , , , CC: Eugen Hristev Subject: [PATCH v2 04/10] iio: inkern: add module put/get on iio dev module when requesting channels Date: Tue, 27 Mar 2018 15:32:37 +0300 Message-ID: <1522153963-1121-5-git-send-email-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522153963-1121-1-git-send-email-eugen.hristev@microchip.com> References: <1522153963-1121-1-git-send-email-eugen.hristev@microchip.com> MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When requesting channels for a particular consumer device, besides requesting the device (incrementing the reference counter), also do it for the driver module of the iio dev. This will avoid the situation where the producer IIO device can be removed and the consumer is still present in the kernel. Signed-off-by: Eugen Hristev --- drivers/iio/inkern.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c index ec98790..68d9b87 100644 --- a/drivers/iio/inkern.c +++ b/drivers/iio/inkern.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include "iio_core.h" @@ -152,6 +153,7 @@ static int __of_iio_channel_get(struct iio_channel *channel, if (index < 0) goto err_put; channel->channel = &indio_dev->channels[index]; + try_module_get(channel->indio_dev->driver_module); return 0; @@ -256,8 +258,10 @@ static struct iio_channel *of_iio_channel_get_all(struct device *dev) return chans; error_free_chans: - for (i = 0; i < mapind; i++) + for (i = 0; i < mapind; i++) { + module_put(chans[i].indio_dev->driver_module); iio_device_put(chans[i].indio_dev); + } kfree(chans); return ERR_PTR(ret); } @@ -351,6 +355,7 @@ void iio_channel_release(struct iio_channel *channel) { if (!channel) return; + module_put(channel->indio_dev->driver_module); iio_device_put(channel->indio_dev); kfree(channel); } @@ -482,6 +487,7 @@ void iio_channel_release_all(struct iio_channel *channels) struct iio_channel *chan = &channels[0]; while (chan->indio_dev) { + module_put(chan->indio_dev->driver_module); iio_device_put(chan->indio_dev); chan++; }