| Message ID | 1559434641-11783-1-git-send-email-hongyan.song@intel.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | eca0f0a6c3fb2f88f123b4a8b57d53de77cdde77 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [v3] hid: remove NO_D3 flag when remove driver | expand |
On Sun, 2 Jun 2019, hongyan.song@intel.com wrote: > From: Song Hongyan <hongyan.song@intel.com> > > Remove the NO_D3 flag when remove the driver and let device enter > into D3, it will save more power. > > Signed-off-by: Song Hongyan <hongyan.song@intel.com> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > --- > v3 changes: > After test the former implmentation, we found FW will enter D3 when > system enter into S0i3. Change the implementation to meet the requirement: > device enter D3 and have no impact to ISH platform. Srinivas, I'd prefer changes like this to go to Linus tree in merge window and not -rc phase, so I'll do that unless you tell me there is a good reason to push it to Linus still in -rc. Thanks,
On Wed, 2019-06-26 at 14:07 +0200, Jiri Kosina wrote: > On Sun, 2 Jun 2019, hongyan.song@intel.com wrote: > > > From: Song Hongyan <hongyan.song@intel.com> > > > > Remove the NO_D3 flag when remove the driver and let device enter > > into D3, it will save more power. > > > > Signed-off-by: Song Hongyan <hongyan.song@intel.com> > > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > > --- > > v3 changes: > > After test the former implmentation, we found FW will enter D3 when > > system enter into S0i3. Change the implementation to meet the > > requirement: > > device enter D3 and have no impact to ISH platform. > > Srinivas, I'd prefer changes like this to go to Linus tree in merge > window > and not -rc phase, so I'll do that unless you tell me there is a > good > reason to push it to Linus still in -rc. Correct. I will tell you if it is important enough to go to -rc release, otherwise all changes you can assume for the next merge window. This change is also for the next merge window. Thanks, Srinivas > > Thanks, >
On Wed, 26 Jun 2019, Srinivas Pandruvada wrote: > > Srinivas, I'd prefer changes like this to go to Linus tree in merge > > window and not -rc phase, so I'll do that unless you tell me there is > > a good reason to push it to Linus still in -rc. > Correct. I will tell you if it is important enough to go to -rc > release, otherwise all changes you can assume for the next merge > window. Thanks for your confirmation. Now queued in for-5.3/ish.
Hi, Thanks Jiri& Srinivas for the merge schedule information. BR Hongyan -----Original Message----- From: Jiri Kosina [mailto:jikos@kernel.org] Sent: Thursday, June 27, 2019 5:35 AM To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: Song, Hongyan <hongyan.song@intel.com>; linux-input@vger.kernel.org; linux-iio@vger.kernel.org; hdegoede@redhat.com; jic23@kernel.org; Xu, Even <even.xu@intel.com> Subject: Re: [PATCH v3] hid: remove NO_D3 flag when remove driver On Wed, 26 Jun 2019, Srinivas Pandruvada wrote: > > Srinivas, I'd prefer changes like this to go to Linus tree in merge > > window and not -rc phase, so I'll do that unless you tell me there > > is a good reason to push it to Linus still in -rc. > Correct. I will tell you if it is important enough to go to -rc > release, otherwise all changes you can assume for the next merge > window. Thanks for your confirmation. Now queued in for-5.3/ish. -- Jiri Kosina SUSE Labs
diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c index b239db2..5daa16f 100644 --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c @@ -193,6 +193,7 @@ static void ish_remove(struct pci_dev *pdev) struct ishtp_device *ishtp_dev = pci_get_drvdata(pdev); ishtp_bus_remove_all_clients(ishtp_dev, false); + pdev->dev_flags &= ~PCI_DEV_FLAGS_NO_D3; ish_device_disable(ishtp_dev); }