From patchwork Wed Feb 3 05:07:49 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 76600 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o13585Ge006135 for ; Wed, 3 Feb 2010 05:08:05 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750735Ab0BCFIA (ORCPT ); Wed, 3 Feb 2010 00:08:00 -0500 Received: from mail-px0-f182.google.com ([209.85.216.182]:52122 "EHLO mail-px0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725Ab0BCFIA (ORCPT ); Wed, 3 Feb 2010 00:08:00 -0500 Received: by pxi12 with SMTP id 12so995255pxi.33 for ; Tue, 02 Feb 2010 21:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=bdCl62Z2DIncrI3z0IrG2AGzj4vST0prU6gCM5L8kHE=; b=CdxRHMqRWzOZuyrSAKed6m1NOC134NntDkdhFnRKgqFA0CsiALkS24qEpSbdF0o8Y2 wViM7AjZLemdFr8Lk67kUzcmf/LUOqOoZSNSVjzFtgq4zum3YagR7DAONxJ2M7n3BmP4 avPfppBjen+DFvyeMHBQIN8vUNOQPDstsAVWY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=wIvLDoAPxJAwAwTgl1xivaVnF2FkFP04+40dML9eThs4DaQiNJ9NsEMOdrESDpw779 1VVEoqbKN35Y+kfxtDAMy71SmR5yuBjjyj6fiY4iiuDw6m2NVB2CGZZjuddQnL3D/TuN uX1LDElBuY2yY92HrG9JK2pT5KtwKByohnwek= Received: by 10.141.89.15 with SMTP id r15mr4819855rvl.242.1265173675830; Tue, 02 Feb 2010 21:07:55 -0800 (PST) Received: from mailhub.coreip.homeip.net (c-24-6-153-137.hsd1.ca.comcast.net [24.6.153.137]) by mx.google.com with ESMTPS id 22sm6121128pzk.6.2010.02.02.21.07.53 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 02 Feb 2010 21:07:54 -0800 (PST) Date: Tue, 2 Feb 2010 21:07:49 -0800 From: Dmitry Torokhov To: John Kacur Cc: Arnd Bergmann , Thadeu Lima de Souza Cascardo , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro , Andrew Morton Subject: Re: [PATCH] input: remove BKL from uinput open function Message-ID: <20100203050749.GA22110@core.coreip.homeip.net> References: <201001302257.09354.arnd@arndb.de> <520f0cf11001301507k20e3cf8dqa73026e12f3a1767@mail.gmail.com> <201001310520.55813.arnd@arndb.de> <20100131052942.GA12320@core.coreip.homeip.net> <520f0cf11002011222h134dbf06rf1db612da9a9728@mail.gmail.com> <520f0cf11002011227s74e57673j3922941f7ee87989@mail.gmail.com> <20100201212132.GA7380@core.coreip.homeip.net> <520f0cf11002011350u3b541a0cxfb0ed882dca13afe@mail.gmail.com> <20100201220856.GB7380@core.coreip.homeip.net> <520f0cf11002011518y22c2f097s87872e7b5b1690d7@mail.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <520f0cf11002011518y22c2f097s87872e7b5b1690d7@mail.gmail.com> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Wed, 03 Feb 2010 05:08:05 +0000 (UTC) diff --git a/fs/open.c b/fs/open.c index 040cef7..02ceb73 100644 --- a/fs/open.c +++ b/fs/open.c @@ -1200,7 +1200,9 @@ EXPORT_SYMBOL(generic_file_open); /* * This is used by subsystems that don't want seekable - * file descriptors + * file descriptors. The function is not supposed to ever fail, the only + * reason it returns an 'int' and not 'void' is so that it can be plugged + * directly into file_operations structure. */ int nonseekable_open(struct inode *inode, struct file *filp) {