From patchwork Fri Aug 6 08:08:04 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Bruno_Pr=C3=A9mont?= X-Patchwork-Id: 117726 X-Patchwork-Delegate: jikos@jikos.cz Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o768FbxG005286 for ; Fri, 6 Aug 2010 08:15:37 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760718Ab0HFIPg (ORCPT ); Fri, 6 Aug 2010 04:15:36 -0400 Received: from smtprelay.restena.lu ([158.64.1.62]:40301 "EHLO smtprelay.restena.lu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755692Ab0HFIPd (ORCPT ); Fri, 6 Aug 2010 04:15:33 -0400 X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Fri, 06 Aug 2010 08:15:37 +0000 (UTC) X-Greylist: delayed 445 seconds by postgrey-1.27 at vger.kernel.org; Fri, 06 Aug 2010 04:15:33 EDT Received: from smtprelay.restena.lu (localhost [127.0.0.1]) by smtprelay.restena.lu (Postfix) with ESMTP id E98DD105FD; Fri, 6 Aug 2010 10:08:04 +0200 (CEST) Received: from pluto.restena.lu (pluto.restena.lu [IPv6:2001:a18:1:8:230:5ff:fefe:5152]) by smtprelay.restena.lu (Postfix) with ESMTPS id ACFFC10592; Fri, 6 Aug 2010 10:08:04 +0200 (CEST) Date: Fri, 6 Aug 2010 10:08:04 +0200 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Dan Carpenter , Jiri Kosina Cc: Jaya Kumar , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] hid: picolcd: testing the wrong variable Message-ID: <20100806100804.4b920829@pluto.restena.lu> In-Reply-To: <20100806062848.GL9031@bicker> References: <20100806062848.GL9031@bicker> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Virus-Scanned: ClamAV Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org --- a/drivers/hid/hid-picolcd.c +++ b/drivers/hid/hid-picolcd.c @@ -547,11 +547,11 @@ static void picolcd_fb_destroy(struct fb ref_cnt--; mutex_lock(&info->lock); (*ref_cnt)--; - may_release = !ref_cnt; + may_release = !*ref_cnt; mutex_unlock(&info->lock); if (may_release) { - framebuffer_release(info); vfree((u8 *)info->fix.smem_start); + framebuffer_release(info); } }