From patchwork Wed Oct 27 20:26:05 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 286592 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o9RKQLb7013462 for ; Wed, 27 Oct 2010 20:26:21 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756705Ab0J0U0U (ORCPT ); Wed, 27 Oct 2010 16:26:20 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:46618 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756549Ab0J0U0S (ORCPT ); Wed, 27 Oct 2010 16:26:18 -0400 Received: by wyf28 with SMTP id 28so1123063wyf.19 for ; Wed, 27 Oct 2010 13:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=XeJ6bj5XucWK/sEH/T+wXe3879mk9rfS5XjeuhIh+iM=; b=s7O2wrSdpE2RH+BriNmUWxRiIJEbG0xAbp0aglHP6pwCZmAlZcDU7aSubmLdsenjwC CuGlXIXIk71FXUW/8V9RocrDRhg8Uew4b/Smm+WCtsCCQetyYu0bP+JiiHUzAq07nzXs 9ZIfS9bEPSiUemqwKU352Ozgf3hEWnIrm29IU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=DsgUZOYTgOBfw/M5sDD9hiEO0fEL7p1kBRD+yyfGwSuJud5Ht4pD9e8kjucw9BkvOC raFBHjHvtI99OPPpZbhBTrVNqdBxOPp286z0vPlzoXnLw8ZiINh5ew+q8q5Oq92j85uJ ct+0p4Mc2pZEn0sEHY1GDvaQa2gYw1XvWjOR8= Received: by 10.216.50.75 with SMTP id y53mr9590698web.85.1288211177259; Wed, 27 Oct 2010 13:26:17 -0700 (PDT) Received: from bicker (h2db5.n1.ips.mtn.co.ug [41.210.173.181]) by mx.google.com with ESMTPS id x23sm139998weq.10.2010.10.27.13.26.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 27 Oct 2010 13:26:15 -0700 (PDT) Date: Wed, 27 Oct 2010 22:26:05 +0200 From: Dan Carpenter To: Dmitry Torokhov Cc: Henrik Rydberg , Naveen Kumar Gaddipati , Linus Walleij , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch v2] touchscreen/bu21013_ts: null dereference in error handling Message-ID: <20101027202605.GH6062@bicker> References: <20101027100822.GF6062@bicker> <20101027154613.GA8745@core.coreip.homeip.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20101027154613.GA8745@core.coreip.homeip.net> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Wed, 27 Oct 2010 20:26:21 +0000 (UTC) diff --git a/drivers/input/touchscreen/bu21013_ts.c b/drivers/input/touchscreen/bu21013_ts.c index ccde586..2ca9e5d 100644 --- a/drivers/input/touchscreen/bu21013_ts.c +++ b/drivers/input/touchscreen/bu21013_ts.c @@ -514,7 +514,7 @@ err_free_irq: err_cs_disable: pdata->cs_dis(pdata->cs_pin); err_free_mem: - input_free_device(bu21013_data->in_dev); + input_free_device(in_dev); kfree(bu21013_data); return error;