From patchwork Tue Nov 30 13:54:05 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Antonio Ospite <ospite@studenti.unina.it>
X-Patchwork-Id: 366921
X-Patchwork-Delegate: jikos@jikos.cz
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oAUDsKmj028033
	for <patchwork-linux-input@patchwork.kernel.org>;
	Tue, 30 Nov 2010 13:54:23 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752052Ab0K3NyR (ORCPT
	<rfc822;patchwork-linux-input@patchwork.kernel.org>);
	Tue, 30 Nov 2010 08:54:17 -0500
Received: from smtp209.alice.it ([82.57.200.105]:35894 "EHLO
	smtp209.alice.it"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751761Ab0K3NyR (ORCPT <rfc822;linux-input@vger.kernel.org>);
	Tue, 30 Nov 2010 08:54:17 -0500
Received: from jcn (82.57.79.90) by smtp209.alice.it (8.5.124.08)
	(authenticated as fospite@alice.it)
	id 4C1A27590B6D980D; Tue, 30 Nov 2010 14:54:15 +0100
Date: Tue, 30 Nov 2010 14:54:05 +0100
From: Antonio Ospite <ospite@studenti.unina.it>
To: linux-input@vger.kernel.org
Cc: linux-bluetooth@vger.kernel.org, Bastien Nocera <hadess@hadess.net>,
	Marcel Holtmann <marcel@holtmann.org>, Jiri Kosina <jkosina@suse.cz>,
	Alan Ott <alan@signal11.us>
Subject: hidp_output_raw_report, HID_OUTPUT_REPORT and Sixaxis
Message-Id: <20101130145405.d8142bc3.ospite@studenti.unina.it>
X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu)
X-Face: z*RaLf`X<@C75u6Ig9}{oW$H; 1_\2t5)({*|jhM<pyWR#k60!#=#>/Vb;
	]yA5<GWI5`6u&+ ; 6b'@y|8w"wB;
	4/e!7wYYrcqdJFY,~%Gk_4]cq$Ei/7<j&N3ah(m`ku?pX.&+~:_/wC~dwn^)MizBG
	!pE^+iDQQ1yC6^,)YDKkxDd!T>\I~93>J<_`<4)A{':UrE
Mime-Version: 1.0
Sender: linux-input-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-input.vger.kernel.org>
X-Mailing-List: linux-input@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]);
	Tue, 30 Nov 2010 13:54:23 +0000 (UTC)


different report types was added to hidp, however in my Sixaxis
experiments setting leds (sending and output report) was not working
until I made this change:

diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index b68a608..0c443b7 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -402,7 +402,7 @@ static int hidp_output_raw_report(struct hid_device *hid, unsigned char *data, s
 		report_type = HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE;
 		break;
 	case HID_OUTPUT_REPORT:
-		report_type = HIDP_TRANS_DATA | HIDP_DATA_RTYPE_OUPUT;
+		report_type = HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_OUPUT;
 		break;
 	default:
 		return -EINVAL;