diff mbox

[2/2] Input: kxtj9: fix locking typo in kxtj9_set_poll()

Message ID 20110720053108.GE6445@shale.localdomain (mailing list archive)
State Accepted
Commit 6eab7ce65a4e6fae1d2cb5d866515ed288f2fdcc
Headers show

Commit Message

Dan Carpenter July 20, 2011, 5:31 a.m. UTC
According to the comments we want to call mutex_lock() here instead
of mutex_unlock().  That makes more sense.

Signed-off-by: Dan Carpenter <error27@gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Dmitry Torokhov July 20, 2011, 6:19 a.m. UTC | #1
On Wed, Jul 20, 2011 at 08:31:08AM +0300, Dan Carpenter wrote:
> According to the comments we want to call mutex_lock() here instead
> of mutex_unlock().  That makes more sense.
> 

Applied both, thanks Dan.
diff mbox

Patch

diff --git a/drivers/input/misc/kxtj9.c b/drivers/input/misc/kxtj9.c
index 6c96dc3..c456f63 100644
--- a/drivers/input/misc/kxtj9.c
+++ b/drivers/input/misc/kxtj9.c
@@ -362,7 +362,7 @@  static ssize_t kxtj9_set_poll(struct device *dev, struct device_attribute *attr,
 		return error;
 
 	/* Lock the device to prevent races with open/close (and itself) */
-	mutex_unlock(&input_dev->mutex);
+	mutex_lock(&input_dev->mutex);
 
 	disable_irq(client->irq);