From patchwork Fri Jul 29 05:10:44 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Rothwell X-Patchwork-Id: 1018962 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6T5BA3c008905 for ; Fri, 29 Jul 2011 05:11:11 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754565Ab1G2FKu (ORCPT ); Fri, 29 Jul 2011 01:10:50 -0400 Received: from chilli.pcug.org.au ([203.10.76.44]:32834 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754518Ab1G2FKt (ORCPT ); Fri, 29 Jul 2011 01:10:49 -0400 Received: from canb.auug.org.au (ibmaus65.lnk.telstra.net [165.228.126.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtps.tip.net.au (Postfix) with ESMTPSA id 52AC9144ACD; Fri, 29 Jul 2011 15:10:45 +1000 (EST) Date: Fri, 29 Jul 2011 15:10:44 +1000 From: Stephen Rothwell To: Paul Gortmaker Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Dan Carpenter , linux-input@vger.kernel.org Subject: linux-next: build failure after merge of the moduleh tree Message-Id: <20110729151044.49f8bfdeeadb8edaf583f90d@canb.auug.org.au> X-Mailer: Sylpheed 3.2.0beta1 (GTK+ 2.24.5; i486-pc-linux-gnu) Mime-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 29 Jul 2011 05:11:11 +0000 (UTC) Hi Paul, After merging the moduleh tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/input/misc/kxtj9.c:644:1: warning: data definition has no type or storage class drivers/input/misc/kxtj9.c:644:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' drivers/input/misc/kxtj9.c:644:1: warning: parameter names (without types) in function declaration drivers/input/misc/kxtj9.c:649:12: error: 'THIS_MODULE' undeclared here (not in a function) drivers/input/misc/kxtj9.c:669:20: error: expected declaration specifiers or '...' before string constant drivers/input/misc/kxtj9.c:669:1: warning: data definition has no type or storage class drivers/input/misc/kxtj9.c:669:1: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/input/misc/kxtj9.c:669:20: warning: function declaration isn't a prototype drivers/input/misc/kxtj9.c:670:15: error: expected declaration specifiers or '...' before string constant drivers/input/misc/kxtj9.c:670:1: warning: data definition has no type or storage class drivers/input/misc/kxtj9.c:670:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/input/misc/kxtj9.c:670:15: warning: function declaration isn't a prototype drivers/input/misc/kxtj9.c:671:16: error: expected declaration specifiers or '...' before string constant drivers/input/misc/kxtj9.c:671:1: warning: data definition has no type or storage class drivers/input/misc/kxtj9.c:671:1: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/input/misc/kxtj9.c:671:16: warning: function declaration isn't a prototype drivers/input/misc/kxtj9.c: In function 'kxtj9_init': drivers/input/misc/kxtj9.c:660:1: warning: control reaches end of non-void function I have added this patch for today: From: Stephen Rothwell Date: Fri, 29 Jul 2011 15:06:46 +1000 Subject: [PATCH] kxtj9: explictly include module.h since some of its facilities are used. Signed-off-by: Stephen Rothwell --- drivers/input/misc/kxtj9.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/input/misc/kxtj9.c b/drivers/input/misc/kxtj9.c index c456f63..783597a 100644 --- a/drivers/input/misc/kxtj9.c +++ b/drivers/input/misc/kxtj9.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include #include