From patchwork Mon Sep 16 09:37:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Juergen Borleis X-Patchwork-Id: 2896211 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6FB9B9F1C0 for ; Mon, 16 Sep 2013 09:36:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8428020212 for ; Mon, 16 Sep 2013 09:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4277F2013D for ; Mon, 16 Sep 2013 09:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688Ab3IPJgS (ORCPT ); Mon, 16 Sep 2013 05:36:18 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:49199 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752270Ab3IPJgS convert rfc822-to-8bit (ORCPT ); Mon, 16 Sep 2013 05:36:18 -0400 Received: from thebe.hi.pengutronix.de ([2001:6f8:1178:2:5e26:aff:fe2b:7cc4]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1VLVE1-0004iv-4E; Mon, 16 Sep 2013 11:36:09 +0200 From: =?iso-8859-1?q?J=FCrgen_Beisert?= Organization: Pengutronix e.K. To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection Date: Mon, 16 Sep 2013 11:37:31 +0200 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: devel@driverdev.osuosl.org, marex@denx.de, fabio.estevam@freescale.com, linux-iio@vger.kernel.org, Torokhov , jic23@cam.ac.uk, "linux-input@vger.kernel.org" , Jonathan Cameron References: <1378887511-24530-1-git-send-email-jbe@pengutronix.de> <52359259.8010202@kernel.org> <201309161010.22151.jbe@pengutronix.de> In-Reply-To: <201309161010.22151.jbe@pengutronix.de> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Disposition: inline Message-Id: <201309161137.31411.jbe@pengutronix.de> X-SA-Exim-Connect-IP: 2001:6f8:1178:2:5e26:aff:fe2b:7cc4 X-SA-Exim-Mail-From: jbe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-input@vger.kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Jonathan, On Monday 16 September 2013 10:10:22 Jürgen Beisert wrote: > [...] > > While this driver is placed in IIO within staging at the moment, these > > changes are definitely input related. Hence I have cc'd Dmitry and the > > input list. > > > > I am personaly a little uncomfortable that we have such a complex bit of > > input code sat within an IIO driver but such is life. > > Maybe an MFD for this ADC unit would be a better way to go? Currently I > have a different problem with this driver, because the ADC unit monitors > the battery as well. And the charging driver from the power subsystem needs > these values to charge the battery in a correct manner. I would suggest: Regards, Juergen diff --git a/drivers/staging/iio/TODO b/drivers/staging/iio/TODO index 04c2326..c22a0ed 100644 --- a/drivers/staging/iio/TODO +++ b/drivers/staging/iio/TODO @@ -13,6 +13,17 @@ Would be nice 3) Expand device set. Lots of other maxim adc's have very similar interfaces. +MXS LRADC driver: +This is a classic MFD device as it combines the following subdevices + - touchscreen controller (input subsystem related device) + - general purpose ADC channels + - battery voltage monitor (power subsystem related device) + - die temperature monitor (thermal management) + +At least the battery voltage and die temperature feature is required in-kernel +by a driver of the SoC's battery charging unit to avoid any damage to the +silicon and the battery. + TSL2561 Would be nice 1) Open question of userspace vs kernel space balance when