From patchwork Tue Nov 3 07:21:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 7540331 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6D477BF90C for ; Tue, 3 Nov 2015 07:25:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 933F220988 for ; Tue, 3 Nov 2015 07:25:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CA9B20984 for ; Tue, 3 Nov 2015 07:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753354AbbKCHV7 (ORCPT ); Tue, 3 Nov 2015 02:21:59 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34065 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752708AbbKCHV6 (ORCPT ); Tue, 3 Nov 2015 02:21:58 -0500 Received: by padhx2 with SMTP id hx2so2921517pad.1; Mon, 02 Nov 2015 23:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=+PkUNjxt2/AvAqc6v/WqsSgzpWDz5o41dNLmIYIX19o=; b=yJak0f2iMGCSguDgaknV6gCaPcp7qmCya/XxG/4C7O+REJ1nQ2tK77PYuMSvYHYdWy PGyxeHj2F9G6+sXLRnD5g/+nj2WVoDNTanxSbTSw47g4YhOMoOA1PiI17B2CJXEW4qov APgaIub0FdQj8iwrsloJML5X0je+/e/ai2Xzr2SNFb7R4aVSSlDiNB43hI1ekFtGM/PD nY4WaT9OazKQK2CPAPhzKlCGVMG0xF4rNUu6ADVCe8FCt+KqSfkDekEk/gTvvIydBGjS A5wiowJjJFQnHUrqRTkIRcE+vLYBK7SuvuSLup9bR7Obrp1irI1s6O79WN4uKm4VRTic NeJA== X-Received: by 10.68.103.161 with SMTP id fx1mr31971535pbb.42.1446535317669; Mon, 02 Nov 2015 23:21:57 -0800 (PST) Received: from dtor-ws ([172.22.64.149]) by smtp.gmail.com with ESMTPSA id b6sm27667893pbu.90.2015.11.02.23.21.56 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 02 Nov 2015 23:21:56 -0800 (PST) Date: Mon, 2 Nov 2015 23:21:24 -0800 From: Dmitry Torokhov To: Michael Welling Cc: Rob Herring , kbuild test robot , kbuild-all@01.org, Tony Lindgren , Pavel Machek , Felipe Balbi , Sebastian Reichel , Roger Quadros , Arnd Bergmann , Mark Brown , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" Subject: Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings Message-ID: <20151103072124.GA33601@dtor-ws> References: <1446252086-24334-1-git-send-email-mwelling@ieee.org> <1446252086-24334-5-git-send-email-mwelling@ieee.org> <20151102205028.GA2571@deathstar> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151102205028.GA2571@deathstar> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Nov 02, 2015 at 02:50:29PM -0600, Michael Welling wrote: > On Mon, Nov 02, 2015 at 09:19:50AM -0600, Rob Herring wrote: > > > +Required properties: > > > + - compatible : "ti,tsc2004" > > > + - interrupts : IRQ specifier > > > + - vio-supply : Regulator specifier > > > > reg property? > > Rob, > > It appears that I missed this in the description. > > Probably because I was following the lead of the ts2005 description. > > How does this look: > - reg : I2C address. 0x48 - 0x4b based on the voltage applied to > the AD1 and AD0 inputs on the IC. > How about the version below? Thanks. Acked-by: Rob Herring diff --git a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt index 09089a6..b80c04b 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt +++ b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt @@ -1,14 +1,15 @@ -* Texas Instruments tsc2005 touchscreen controller +* Texas Instruments tsc2004 and tsc2005 touchscreen controllers Required properties: - - compatible : "ti,tsc2005" - - reg : SPI device address - - spi-max-frequency : Maximal SPI speed + - compatible : "ti,tsc2004" or "ti,tsc2005" + - reg : Device address - interrupts : IRQ specifier - - reset-gpios : GPIO specifier - - vio-supply : Regulator specifier + - spi-max-frequency : Maximum SPI clocking speed of the device + (for tsc2005) Optional properties: + - vio-supply : Regulator specifier + - reset-gpios : GPIO specifier for the controller reset line - ti,x-plate-ohms : integer, resistance of the touchscreen's X plates in ohm (defaults to 280) - ti,esd-recovery-timeout-ms : integer, if the touchscreen does not respond after @@ -18,6 +19,27 @@ Optional properties: Example: +&i2c3 { + tsc2004@48 { + compatible = "ti,tsc2004"; + reg = <0x48>; + vio-supply = <&vio>; + + reset-gpios = <&gpio4 8 GPIO_ACTIVE_HIGH>; + interrupts-extended = <&gpio1 27 IRQ_TYPE_EDGE_RISING>; + + touchscreen-fuzz-x = <4>; + touchscreen-fuzz-y = <7>; + touchscreen-fuzz-pressure = <2>; + touchscreen-size-x = <4096>; + touchscreen-size-y = <4096>; + touchscreen-max-pressure = <2048>; + + ti,x-plate-ohms = <280>; + ti,esd-recovery-timeout-ms = <8000>; + }; +} + &mcspi1 { tsc2005@0 { compatible = "ti,tsc2005";