From patchwork Thu Dec 10 09:37:13 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Twiss X-Patchwork-Id: 7817881 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 53FEDBEEE1 for ; Thu, 10 Dec 2015 09:43:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6B7E52056E for ; Thu, 10 Dec 2015 09:43:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 373C42056D for ; Thu, 10 Dec 2015 09:43:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752291AbbLJJnf (ORCPT ); Thu, 10 Dec 2015 04:43:35 -0500 Received: from mail1.bemta3.messagelabs.com ([195.245.230.168]:32701 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbbLJJnd (ORCPT ); Thu, 10 Dec 2015 04:43:33 -0500 X-Greylist: delayed 418 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Dec 2015 04:43:33 EST Received: from [85.158.137.3] by server-8.bemta-3.messagelabs.com id 69/C9-31069-1A749665; Thu, 10 Dec 2015 09:36:33 +0000 X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-13.tower-38.messagelabs.com!1449740192!10050677!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 11434 invoked from network); 10 Dec 2015 09:36:33 -0000 Received: from mailrelay2.diasemi.com (HELO sw-ex-cashub01.diasemi.com) (94.185.165.51) by server-13.tower-38.messagelabs.com with AES128-SHA encrypted SMTP; 10 Dec 2015 09:36:33 -0000 Received: from swsrvapps-01.diasemi.com (10.20.28.141) by SW-EX-CASHUB01.diasemi.com (10.20.16.140) with Microsoft SMTP Server id 14.3.248.2; Thu, 10 Dec 2015 09:36:32 +0000 Received: by swsrvapps-01.diasemi.com (Postfix, from userid 22547) id 5DF333FBD7; Thu, 10 Dec 2015 09:36:32 +0000 (GMT) From: Steve Twiss Date: Thu, 10 Dec 2015 09:37:13 +0000 Subject: [PATCH V2] input: da9063: report KEY_POWER instead of KEY_SLEEP during power key-press To: Dmitry Torokhov , LINUX-INPUT , LINUXKERNEL CC: David Dajun Chen , Support Opensource Message-ID: <20151210093632.5DF333FBD7@swsrvapps-01.diasemi.com> MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Steve Twiss Stop reporting KEY_SLEEP for a short key-press and report KEY_POWER instead This change applies to both DA9063 and DA9062 ONKEY drivers. A previous application used for testing by the developer required a KEY_SLEEP and KEY_POWER input_report_key event to distinguish between a short and long key-press of the power key. This is not the general convention and the typical solution is for KEY_POWER to be used in both cases: suspend and S/W power off. Signed-off-by: Steve Twiss --- This patch applies against linux-next and v4.4-rc4 Dmitry, Now I realise what you meant in a previous review of this driver. - https://lkml.org/lkml/2015/4/17/618 > Why do we handle KEY_POWER and KEY_SLEEP completely differently? Because my testing assumed KEY_SLEEP was linked to suspend and KEY_POWER was linked to S/W power off - https://lkml.org/lkml/2015/4/29/406 > (1) short press & release -- SLEEP > (2) long press & release -- POWER This change removes the reporting of KEY_SLEEP that was specific to my test framework and replaces it with the intended KEY_POWER. Regards, Steve Twiss, Dialog Semiconductor Ltd. drivers/input/misc/da9063_onkey.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c index 8eb697d..bb863e0 100644 --- a/drivers/input/misc/da9063_onkey.c +++ b/drivers/input/misc/da9063_onkey.c @@ -179,13 +179,13 @@ static irqreturn_t da9063_onkey_irq_handler(int irq, void *data) input_report_key(onkey->input, KEY_POWER, 1); input_sync(onkey->input); schedule_delayed_work(&onkey->work, 0); - dev_dbg(onkey->dev, "KEY_POWER pressed.\n"); + dev_dbg(onkey->dev, "KEY_POWER long press.\n"); } else { - input_report_key(onkey->input, KEY_SLEEP, 1); + input_report_key(onkey->input, KEY_POWER, 1); input_sync(onkey->input); - input_report_key(onkey->input, KEY_SLEEP, 0); + input_report_key(onkey->input, KEY_POWER, 0); input_sync(onkey->input); - dev_dbg(onkey->dev, "KEY_SLEEP pressed.\n"); + dev_dbg(onkey->dev, "KEY_POWER short press.\n"); } return IRQ_HANDLED;