MOUSE_PS2_VMMOUSE and input/mice

Commit Message

Dmitry Torokhov Jan. 16, 2016, 6:16 p.m. UTC

On Sat, Jan 16, 2016 at 05:39:45PM +0200, Lauri Kasanen wrote:
> Hi,
> 
> Here's the /proc/bus/input/devices output. Also attaching the kernel
> config in case it'd be useful.
> 

...

> 
> I: Bus=0011 Vendor=0002 Product=0013 Version=0006
> N: Name="VirtualPS/2 VMware VMMouse"
> P: Phys=isa0060/serio1/input1
> S: Sysfs=/devices/platform/i8042/serio1/input/input4
> U: Uniq=
> H: Handlers=event2 
> B: PROP=0
> B: EV=b
> B: KEY=70000 0 0 0 0 0 0 0 0
>

So mousedev indeed did not bind to the absolute portion of the device.
Please try the patch below.

Comments

Lauri Kasanen Jan. 18, 2016, 8:30 a.m. UTC | #1

On Sat, 16 Jan 2016 10:16:35 -0800
Dmitry Torokhov <[e-mail]> wrote:

> So mousedev indeed did not bind to the absolute portion of the device.
> Please try the patch below.

Hi,

The tester reports the patch works. It has some issues in that pixels
moved in-VM do not match pixels moved in the host screen, but at least
the mouse moves now.

- Lauri
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/input/mouse/vmmouse.c b/drivers/input/mouse/vmmouse.c
index e272f06..a3f0f5a 100644
--- a/drivers/input/mouse/vmmouse.c
+++ b/drivers/input/mouse/vmmouse.c
@@ -458,8 +458,6 @@  int vmmouse_init(struct psmouse *psmouse)
 	priv->abs_dev = abs_dev;
 	psmouse->private = priv;
 
-	input_set_capability(rel_dev, EV_REL, REL_WHEEL);
-
 	/* Set up and register absolute device */
 	snprintf(priv->phys, sizeof(priv->phys), "%s/input1",
 		 psmouse->ps2dev.serio->phys);
@@ -475,10 +473,6 @@  int vmmouse_init(struct psmouse *psmouse)
 	abs_dev->id.version = psmouse->model;
 	abs_dev->dev.parent = &psmouse->ps2dev.serio->dev;
 
-	error = input_register_device(priv->abs_dev);
-	if (error)
-		goto init_fail;
-
 	/* Set absolute device capabilities */
 	input_set_capability(abs_dev, EV_KEY, BTN_LEFT);
 	input_set_capability(abs_dev, EV_KEY, BTN_RIGHT);
@@ -488,6 +482,13 @@  int vmmouse_init(struct psmouse *psmouse)
 	input_set_abs_params(abs_dev, ABS_X, 0, VMMOUSE_MAX_X, 0, 0);
 	input_set_abs_params(abs_dev, ABS_Y, 0, VMMOUSE_MAX_Y, 0, 0);
 
+	error = input_register_device(priv->abs_dev);
+	if (error)
+		goto init_fail;
+
+	/* Add wheel capability to the relative device */
+	input_set_capability(rel_dev, EV_REL, REL_WHEEL);
+
 	psmouse->protocol_handler = vmmouse_process_byte;
 	psmouse->disconnect = vmmouse_disconnect;
 	psmouse->reconnect = vmmouse_reconnect;