[0216/1285] Replace numeric parameter like 0444 with macro

Commit Message

baolex.ni Aug. 2, 2016, 10:50 a.m. UTC

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <[e-mail]>
Signed-off-by: Baole Ni <[e-mail]>
---
 drivers/hid/hid-apple.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Patch

diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index 884d82f..a59441c 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -37,17 +37,17 @@ 
 #define APPLE_FLAG_FKEY		0x01
 
 static unsigned int fnmode = 1;
-module_param(fnmode, uint, 0644);
+module_param(fnmode, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(fnmode, "Mode of fn key on Apple keyboards (0 = disabled, "
 		"[1] = fkeyslast, 2 = fkeysfirst)");
 
 static unsigned int iso_layout = 1;
-module_param(iso_layout, uint, 0644);
+module_param(iso_layout, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(iso_layout, "Enable/Disable hardcoded ISO-layout of the keyboard. "
 		"(0 = disabled, [1] = enabled)");
 
 static unsigned int swap_opt_cmd;
-module_param(swap_opt_cmd, uint, 0644);
+module_param(swap_opt_cmd, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(swap_opt_cmd, "Swap the Option (\"Alt\") and Command (\"Flag\") keys. "
 		"(For people who want to keep Windows PC keyboard muscle memory. "
 		"[0] = as-is, Mac layout. 1 = swapped, Windows layout.)");