From patchwork Tue Aug 2 10:50:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "baolex.ni" X-Patchwork-Id: 9255715 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B01186089F for ; Tue, 2 Aug 2016 11:29:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9F1B4284EF for ; Tue, 2 Aug 2016 11:29:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9151A28515; Tue, 2 Aug 2016 11:29:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 32C75284F6 for ; Tue, 2 Aug 2016 11:29:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754756AbcHBL3Q (ORCPT ); Tue, 2 Aug 2016 07:29:16 -0400 Received: from mga04.intel.com ([192.55.52.120]:1129 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113AbcHBL2v (ORCPT ); Tue, 2 Aug 2016 07:28:51 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 02 Aug 2016 04:28:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1006930823" Received: from shsibuild003.sh.intel.com ([10.239.146.225]) by orsmga001.jf.intel.com with ESMTP; 02 Aug 2016 04:28:17 -0700 From: Baole Ni To: jikos@kernel.org, benjamin.tissoires@redhat.com, thellstrom@vmware.com, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com, dougthompson@xmission.com, bp@alien8.de Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, alexander.deucher@amd.com, ville.syrjala@linux.intel.com Subject: [PATCH 0218/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:50:39 +0800 Message-Id: <20160802105039.28287-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/hid/hid-corsair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-corsair.c b/drivers/hid/hid-corsair.c index 717704e..5353847 100644 --- a/drivers/hid/hid-corsair.c +++ b/drivers/hid/hid-corsair.c @@ -370,8 +370,8 @@ static ssize_t k90_store_current_profile(struct device *dev, return count; } -static DEVICE_ATTR(macro_mode, 0644, k90_show_macro_mode, k90_store_macro_mode); -static DEVICE_ATTR(current_profile, 0644, k90_show_current_profile, +static DEVICE_ATTR(macro_mode, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, k90_show_macro_mode, k90_store_macro_mode); +static DEVICE_ATTR(current_profile, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, k90_show_current_profile, k90_store_current_profile); static struct attribute *k90_attrs[] = {