From patchwork Tue Aug 2 10:55:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "baolex.ni" X-Patchwork-Id: 9259723 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CF26360865 for ; Tue, 2 Aug 2016 17:52:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C798028489 for ; Tue, 2 Aug 2016 17:52:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BC43C284F9; Tue, 2 Aug 2016 17:52:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6F6B328489 for ; Tue, 2 Aug 2016 17:52:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756881AbcHBRtm (ORCPT ); Tue, 2 Aug 2016 13:49:42 -0400 Received: from mga09.intel.com ([134.134.136.24]:10792 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756150AbcHBLny (ORCPT ); Tue, 2 Aug 2016 07:43:54 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 02 Aug 2016 04:33:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028252394" Received: from shsibuild003.sh.intel.com ([10.239.146.225]) by orsmga002.jf.intel.com with ESMTP; 02 Aug 2016 04:33:33 -0700 From: Baole Ni To: michael.hennerich@analog.com, dmitry.torokhov@gmail.com, hal.rosenstock@gmail.com, dledford@redhat.com, sean.hefty@intel.com, bp@alien8.de Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, haggaie@mellanox.com Subject: [PATCH 0277/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:55:55 +0800 Message-Id: <20160802105555.32276-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/input/misc/adxl34x.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c index 2b2d02f..dd5c8ff 100644 --- a/drivers/input/misc/adxl34x.c +++ b/drivers/input/misc/adxl34x.c @@ -477,7 +477,7 @@ static ssize_t adxl34x_disable_store(struct device *dev, return count; } -static DEVICE_ATTR(disable, 0664, adxl34x_disable_show, adxl34x_disable_store); +static DEVICE_ATTR(disable, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adxl34x_disable_show, adxl34x_disable_store); static ssize_t adxl34x_calibrate_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -524,7 +524,7 @@ static ssize_t adxl34x_calibrate_store(struct device *dev, return count; } -static DEVICE_ATTR(calibrate, 0664, +static DEVICE_ATTR(calibrate, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adxl34x_calibrate_show, adxl34x_calibrate_store); static ssize_t adxl34x_rate_show(struct device *dev, @@ -559,7 +559,7 @@ static ssize_t adxl34x_rate_store(struct device *dev, return count; } -static DEVICE_ATTR(rate, 0664, adxl34x_rate_show, adxl34x_rate_store); +static DEVICE_ATTR(rate, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adxl34x_rate_show, adxl34x_rate_store); static ssize_t adxl34x_autosleep_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -597,7 +597,7 @@ static ssize_t adxl34x_autosleep_store(struct device *dev, return count; } -static DEVICE_ATTR(autosleep, 0664, +static DEVICE_ATTR(autosleep, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, adxl34x_autosleep_show, adxl34x_autosleep_store); static ssize_t adxl34x_position_show(struct device *dev, @@ -639,7 +639,7 @@ static ssize_t adxl34x_write_store(struct device *dev, return count; } -static DEVICE_ATTR(write, 0664, NULL, adxl34x_write_store); +static DEVICE_ATTR(write, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, NULL, adxl34x_write_store); #endif static struct attribute *adxl34x_attributes[] = {