diff mbox

[0281/1285] Replace numeric parameter like 0444 with macro

Message ID 20160802105618.32547-1-baolex.ni@intel.com (mailing list archive)
State Rejected
Headers show

Commit Message

baolex.ni Aug. 2, 2016, 10:56 a.m. UTC 
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/input/mouse/bcm5974.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
index 30e3442..caa8bf9 100644
--- a/drivers/input/mouse/bcm5974.c
+++ b/drivers/input/mouse/bcm5974.c
@@ -174,7 +174,7 @@  MODULE_LICENSE("GPL");
 	{ if (debug >= level) printk(KERN_DEBUG format, ##a); }
 
 static int debug = 1;
-module_param(debug, int, 0644);
+module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(debug, "Activate debugging output");
 
 /* button data structure */