From patchwork Tue Aug 2 10:57:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "baolex.ni" X-Patchwork-Id: 9258231 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3770F6089F for ; Tue, 2 Aug 2016 15:33:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2A07228510 for ; Tue, 2 Aug 2016 15:33:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1E75428544; Tue, 2 Aug 2016 15:33:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B5A128510 for ; Tue, 2 Aug 2016 15:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966987AbcHBPaA (ORCPT ); Tue, 2 Aug 2016 11:30:00 -0400 Received: from mga04.intel.com ([192.55.52.120]:61229 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934897AbcHBM3E (ORCPT ); Tue, 2 Aug 2016 08:29:04 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP; 02 Aug 2016 04:34:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028252769" Received: from shsibuild003.sh.intel.com ([10.239.146.225]) by orsmga002.jf.intel.com with ESMTP; 02 Aug 2016 04:34:39 -0700 From: Baole Ni To: michael.hennerich@analog.com, dmitry.torokhov@gmail.com, hal.rosenstock@gmail.com, dledford@redhat.com, sean.hefty@intel.com, bp@alien8.de Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0288/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:57:01 +0800 Message-Id: <20160802105701.569-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/input/touchscreen/ad7877.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c index 9c250ae..85e6135 100644 --- a/drivers/input/touchscreen/ad7877.c +++ b/drivers/input/touchscreen/ad7877.c @@ -497,7 +497,7 @@ static ssize_t ad7877_disable_store(struct device *dev, return count; } -static DEVICE_ATTR(disable, 0664, ad7877_disable_show, ad7877_disable_store); +static DEVICE_ATTR(disable, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, ad7877_disable_show, ad7877_disable_store); static ssize_t ad7877_dac_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -527,7 +527,7 @@ static ssize_t ad7877_dac_store(struct device *dev, return count; } -static DEVICE_ATTR(dac, 0664, ad7877_dac_show, ad7877_dac_store); +static DEVICE_ATTR(dac, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, ad7877_dac_show, ad7877_dac_store); static ssize_t ad7877_gpio3_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -558,7 +558,7 @@ static ssize_t ad7877_gpio3_store(struct device *dev, return count; } -static DEVICE_ATTR(gpio3, 0664, ad7877_gpio3_show, ad7877_gpio3_store); +static DEVICE_ATTR(gpio3, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, ad7877_gpio3_show, ad7877_gpio3_store); static ssize_t ad7877_gpio4_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -589,7 +589,7 @@ static ssize_t ad7877_gpio4_store(struct device *dev, return count; } -static DEVICE_ATTR(gpio4, 0664, ad7877_gpio4_show, ad7877_gpio4_store); +static DEVICE_ATTR(gpio4, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, ad7877_gpio4_show, ad7877_gpio4_store); static struct attribute *ad7877_attributes[] = { &dev_attr_temp1.attr,