diff mbox

[0292/1285] Replace numeric parameter like 0444 with macro

Message ID 20160802105725.838-1-baolex.ni@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

baolex.ni Aug. 2, 2016, 10:57 a.m. UTC 
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/input/touchscreen/htcpen.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/drivers/input/touchscreen/htcpen.c b/drivers/input/touchscreen/htcpen.c
index 92e2243..b2e63f3 100644
--- a/drivers/input/touchscreen/htcpen.c
+++ b/drivers/input/touchscreen/htcpen.c
@@ -41,10 +41,10 @@  MODULE_LICENSE("GPL");
 #define Y_AXIS_MAX		2040
 
 static bool invert_x;
-module_param(invert_x, bool, 0644);
+module_param(invert_x, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(invert_x, "If set, X axis is inverted");
 static bool invert_y;
-module_param(invert_y, bool, 0644);
+module_param(invert_y, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(invert_y, "If set, Y axis is inverted");
 
 static irqreturn_t htcpen_interrupt(int irq, void *handle)