From patchwork Tue Aug 2 10:57:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "baolex.ni" X-Patchwork-Id: 9259809 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C0F0B60865 for ; Tue, 2 Aug 2016 18:01:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BA6261FE7B for ; Tue, 2 Aug 2016 18:01:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AF1EE1FFD6; Tue, 2 Aug 2016 18:01:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 70E48279B3 for ; Tue, 2 Aug 2016 18:01:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753629AbcHBLg3 (ORCPT ); Tue, 2 Aug 2016 07:36:29 -0400 Received: from mga01.intel.com ([192.55.52.88]:42143 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755841AbcHBLgY (ORCPT ); Tue, 2 Aug 2016 07:36:24 -0400 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 02 Aug 2016 04:35:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743070394" Received: from shsibuild003.sh.intel.com ([10.239.146.225]) by FMSMGA003.fm.intel.com with ESMTP; 02 Aug 2016 04:35:15 -0700 From: Baole Ni To: dmitry.torokhov@gmail.com, hal.rosenstock@gmail.com, dledford@redhat.com, sean.hefty@intel.com, bp@alien8.de Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, jkosina@suse.com Subject: [PATCH 0294/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:57:37 +0800 Message-Id: <20160802105737.977-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/input/touchscreen/ucb1400_ts.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/ucb1400_ts.c b/drivers/input/touchscreen/ucb1400_ts.c index c1e23cf..c441acc 100644 --- a/drivers/input/touchscreen/ucb1400_ts.c +++ b/drivers/input/touchscreen/ucb1400_ts.c @@ -447,14 +447,14 @@ static struct platform_driver ucb1400_ts_driver = { }; module_platform_driver(ucb1400_ts_driver); -module_param(adcsync, bool, 0444); +module_param(adcsync, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(adcsync, "Synchronize touch readings with ADCSYNC pin."); -module_param(ts_delay, int, 0444); +module_param(ts_delay, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ts_delay, "Delay between panel setup and" " position read. Default = 55us."); -module_param(ts_delay_pressure, int, 0444); +module_param(ts_delay_pressure, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ts_delay_pressure, "delay between panel setup and pressure read." " Default = 0us.");