From patchwork Tue Aug 2 18:56:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 9260335 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EB0AE60865 for ; Tue, 2 Aug 2016 20:07:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF33E283F2 for ; Tue, 2 Aug 2016 20:07:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D3E1F28513; Tue, 2 Aug 2016 20:07:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82C27283F2 for ; Tue, 2 Aug 2016 20:07:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755101AbcHBUHI (ORCPT ); Tue, 2 Aug 2016 16:07:08 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36515 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753897AbcHBUHG (ORCPT ); Tue, 2 Aug 2016 16:07:06 -0400 Received: by mail-pf0-f193.google.com with SMTP id y134so13084337pfg.3; Tue, 02 Aug 2016 13:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=8exnqjqSuCfwD4oogpGQD6QrIUPf41PWWlCrKcnJaRs=; b=afJFlpkRFaUzyqUFgKo6ni2IyRwmPq/yrE/DAetmf0K8U21+Ui3+FiQsA0gaXdhj2V kIOAF5FV/6+jsx1fjlut9BYghReSXsLU/OGn2jH79yIcrTr+oNOLikSpDEO5T2KSzBp/ oJz5VifJyN0rQq4vytoYMq8IpG8caxl8KGh2l+PkZBxEEXUDtrtVeIN0inXtiirUzq2C PJpSDOv0Qrt7Q/wVjo4/wWtM/qA/AAhn6QV7emWguHlIVqZ0yV79bS8CUahxy1byK056 vTsjar/AOE00bUnODAGK0y5v2NULloaOGsfR1zpVC1gzps6XMxS56Ex01OHwkDXLBEoH fy/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=8exnqjqSuCfwD4oogpGQD6QrIUPf41PWWlCrKcnJaRs=; b=Jf2okhMjPym9BlrTwoVr9AjY0z1tArwl8QZz54liGrYR2hVU5lyy9PROz6aQe98Cg7 buFS6qy7TowH9Y5pNiASyO531wdIeuSHo+okCeJ8zlt0X6RrYtit3NqKLILvUtuYRhbC 71EYyBM7PgGSxWFFTuTAtlwhW/3fiZgRiQgvS3VqSSMY83U7Tj98Nxfc8L4JuS4wDAQe 2skWbaK2AvK2KB3wV3TC8xKR4SNUi1tubGv/4ZtfUiE8+eDNh9TBhfOUloDaVkL3fTZP JFtqswAoB4uJeOP8HdkQN9qcZVgP0XGkYbAleTaYOT8iPrSmEZyDhpCD37vIyJEf5UPO eUAA== X-Gm-Message-State: AEkooutX7XgA0qCeEjcI38Sl3D6O9qAo/I8hly1bmD0O6h2Hig7s6WpYT2M2IDOr0yoXwA== X-Received: by 10.98.111.133 with SMTP id k127mr107950259pfc.90.1470164173219; Tue, 02 Aug 2016 11:56:13 -0700 (PDT) Received: from dtor-ws ([2620:0:1000:1311:8cf8:bfac:67b8:4dfe]) by smtp.gmail.com with ESMTPSA id e187sm6596449pfg.43.2016.08.02.11.56.11 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 02 Aug 2016 11:56:11 -0700 (PDT) Date: Tue, 2 Aug 2016 11:56:09 -0700 From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Olivier Sobrie , linux-kernel@vger.kernel.org Subject: [PATCH] Input: ili210x - fix permissions on "calibrate" attribute Message-ID: <20160802185609.GA9952@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP "calibrate" attribute does not provide "show" methods and thus we should not mark it as readable. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/ili210x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c index ddf694b..fe4848b 100644 --- a/drivers/input/touchscreen/ili210x.c +++ b/drivers/input/touchscreen/ili210x.c @@ -169,7 +169,7 @@ static ssize_t ili210x_calibrate(struct device *dev, return count; } -static DEVICE_ATTR(calibrate, 0644, NULL, ili210x_calibrate); +static DEVICE_ATTR(calibrate, S_IWUSR, NULL, ili210x_calibrate); static struct attribute *ili210x_attributes[] = { &dev_attr_calibrate.attr,