From patchwork Tue Feb 7 00:58:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cameron Gutman X-Patchwork-Id: 9558983 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3279C602B1 for ; Tue, 7 Feb 2017 00:59:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1ED2626247 for ; Tue, 7 Feb 2017 00:59:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1326928343; Tue, 7 Feb 2017 00:59:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A4A9426247 for ; Tue, 7 Feb 2017 00:59:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751592AbdBGA7C (ORCPT ); Mon, 6 Feb 2017 19:59:02 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34119 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751414AbdBGA7C (ORCPT ); Mon, 6 Feb 2017 19:59:02 -0500 Received: by mail-pf0-f194.google.com with SMTP id y143so7955054pfb.1; Mon, 06 Feb 2017 16:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=6IjYF+coVjZ3cx9/J1SFyCRLllw8Ta9q4HVWbzrHtfg=; b=Qki5yVlAXd3kfkXvmirztpIZmUC3rB2aBqMSi6vb6FjLJYTrTULwSWEglN3RjR8avm mwyQu4PahnfSWXf07orgAveTGgzXoo2p84lkhrWu/skaLgrpzr7HQB2HLTsZy2YQz/oQ CruT8j/Ct3Qpw8ayei+DfKBpxSXRrvqxgn85P9w+T55VLIoQBDlQbhdU0B0IYo8fnqm7 gfYGm+OfaXCKQbc9tCtl/DY84lXntAOiL+9IHVodtJK5aUKvMF1L1lVfMGsWBPGln4na W/t0HplN+a0BQ8JncGg7V9S240ZCorwcXjee2chY84Sn3BZRcgNRFAd7vHa5kHZ3ANo6 dL1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6IjYF+coVjZ3cx9/J1SFyCRLllw8Ta9q4HVWbzrHtfg=; b=CZdm+P8xBlp/fF0gxjRJYOTJFtBmRrFvFx4LuMTS8LsZbppWJgWw2qqvCyvYKgc/Zf VLsmwDOSXBaKA/bjTOmjBkCB9wCzf6EVAwp8hXhBKKkRNXuZ5nEo1KdjgeCvhsd6/4cW x97bheo/8Y6OPG5ILfQh0ubjI2/6P7PB40Lkdx7lXlbMqCr14gdggLofbXNjJmz6BSgY gh95IqZ1LAKyRnPdFuIyEEp6Btc1vTgxW/225+BjBVE97EL+sbB0Yg5zRxr4rUT4Dz9B 0kW8/720eEnwKcye+IFsjFXoWIB5gSjBFBLMnmnL9YpfhYbyYJY1Ak1Mg6GJ2G/WCu+z IgEA== X-Gm-Message-State: AIkVDXI6qdViTDs43BJZGzABF53dpMacRHiuAJcrBcAy6VfUrfBW2vRlh4LEX+ee5FVI2Q== X-Received: by 10.99.155.18 with SMTP id r18mr16468654pgd.193.1486429141205; Mon, 06 Feb 2017 16:59:01 -0800 (PST) Received: from localhost.localdomain ([174.127.240.168]) by smtp.gmail.com with ESMTPSA id y6sm5602422pgc.1.2017.02.06.16.59.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 16:59:00 -0800 (PST) From: Cameron Gutman To: dmitry.torokhov@gmail.com, rojtberg@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Cameron Gutman Subject: [PATCH v2] Input: xpad - restore LED state after device resume Date: Mon, 6 Feb 2017 16:58:38 -0800 Message-Id: <20170207005838.20095-1-aicommander@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Set the LED_CORE_SUSPENDRESUME flag on our LED device so the LED state will be automatically restored by LED core on resume. Since Xbox One pads stop flashing only when reinitialized, we'll send them the initialization packet so they calm down too. Signed-off-by: Cameron Gutman --- Sending this one alone, since the rest of the series was applied or needs non-trivial reworking. Thanks, Cameron --- drivers/input/joystick/xpad.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index 13975aa..18697f1 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -1240,6 +1240,7 @@ static int xpad_led_probe(struct usb_xpad *xpad) led_cdev = &led->led_cdev; led_cdev->name = led->name; led_cdev->brightness_set = xpad_led_set; + led_cdev->flags = LED_CORE_SUSPENDRESUME; error = led_classdev_register(&xpad->udev->dev, led_cdev); if (error) @@ -1716,8 +1717,16 @@ static int xpad_resume(struct usb_interface *intf) retval = xpad360w_start_input(xpad); } else { mutex_lock(&input->mutex); - if (input->users) + if (input->users) { retval = xpad_start_input(xpad); + } else if (xpad->xtype == XTYPE_XBOXONE) { + /* + * Even if there are no users, we'll send Xbox One pads + * the startup sequence so they don't sit there and + * blink until somebody opens the input device again. + */ + retval = xpad_start_xbox_one(xpad); + } mutex_unlock(&input->mutex); }