| Message ID | 20170220161549.39490-2-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > It's unusual to have error checking like (ret <= 0) in cases when > counting GPIO resources. In case when it's mandatory we propagate the > error (-ENOENT), otherwise we don't use the result. > > This makes consistent behaviour across all possible variants called in > gpiod_count(). > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Mika/Rafael, can you look at this patch? (Andy: sorry for late reply, busy merge window...) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Mar 14, 2017 at 10:43:02AM +0100, Linus Walleij wrote: > On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > It's unusual to have error checking like (ret <= 0) in cases when > > counting GPIO resources. In case when it's mandatory we propagate the > > error (-ENOENT), otherwise we don't use the result. > > > > This makes consistent behaviour across all possible variants called in > > gpiod_count(). > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Mika/Rafael, can you look at this patch? Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > It's unusual to have error checking like (ret <= 0) in cases when > counting GPIO resources. In case when it's mandatory we propagate the > error (-ENOENT), otherwise we don't use the result. > > This makes consistent behaviour across all possible variants called in > gpiod_count(). > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Patch applied with Mika's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index 9b37a3692b3f..d7a22c470312 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -1067,7 +1067,7 @@ int acpi_gpio_count(struct device *dev, const char *con_id) break; } } - if (count >= 0) + if (count > 0) break; } @@ -1083,7 +1083,7 @@ int acpi_gpio_count(struct device *dev, const char *con_id) if (crs_count > 0) count = crs_count; } - return count; + return count ? count : -ENOENT; } struct acpi_crs_lookup {
It's unusual to have error checking like (ret <= 0) in cases when counting GPIO resources. In case when it's mandatory we propagate the error (-ENOENT), otherwise we don't use the result. This makes consistent behaviour across all possible variants called in gpiod_count(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpiolib-acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)