| Message ID | 20170428122855.3185-1-sebastian.reichel@collabora.co.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Apr 28, 2017 at 02:28:54PM +0200, Sebastian Reichel wrote: > The interrupt should be requested for the platform device > and not for the input device. > > Fixes: 7f9ce649d267 ("Input: twl4030-pwrbutton - simplify driver using devm_*") > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> Applied, thank you. > --- > drivers/input/misc/twl4030-pwrbutton.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c > index 54162d2cbcfc..7c4504c31b07 100644 > --- a/drivers/input/misc/twl4030-pwrbutton.c > +++ b/drivers/input/misc/twl4030-pwrbutton.c > @@ -70,7 +70,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev) > pwr->phys = "twl4030_pwrbutton/input0"; > pwr->dev.parent = &pdev->dev; > > - err = devm_request_threaded_irq(&pwr->dev, irq, NULL, powerbutton_irq, > + err = devm_request_threaded_irq(&pdev->dev, irq, NULL, powerbutton_irq, > IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING | > IRQF_ONESHOT, > "twl4030_pwrbutton", pwr); > -- > 2.11.0 >
diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c index 54162d2cbcfc..7c4504c31b07 100644 --- a/drivers/input/misc/twl4030-pwrbutton.c +++ b/drivers/input/misc/twl4030-pwrbutton.c @@ -70,7 +70,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev) pwr->phys = "twl4030_pwrbutton/input0"; pwr->dev.parent = &pdev->dev; - err = devm_request_threaded_irq(&pwr->dev, irq, NULL, powerbutton_irq, + err = devm_request_threaded_irq(&pdev->dev, irq, NULL, powerbutton_irq, IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING | IRQF_ONESHOT, "twl4030_pwrbutton", pwr);
The interrupt should be requested for the platform device and not for the input device. Fixes: 7f9ce649d267 ("Input: twl4030-pwrbutton - simplify driver using devm_*") Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> --- drivers/input/misc/twl4030-pwrbutton.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)