From patchwork Wed May 17 20:59:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Drake X-Patchwork-Id: 9731897 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 822FA60230 for ; Wed, 17 May 2017 21:07:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 448EE28795 for ; Wed, 17 May 2017 21:07:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 35B5B2879E; Wed, 17 May 2017 21:07:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B3EA528795 for ; Wed, 17 May 2017 21:07:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750795AbdEQVHY (ORCPT ); Wed, 17 May 2017 17:07:24 -0400 Received: from mail-ua0-f175.google.com ([209.85.217.175]:35522 "EHLO mail-ua0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdEQVHX (ORCPT ); Wed, 17 May 2017 17:07:23 -0400 Received: by mail-ua0-f175.google.com with SMTP id e55so425651uaa.2 for ; Wed, 17 May 2017 14:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessm-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=Q7w2UPgLeSSdRNhD+ocOvYHd/kwU0wfh+wAb1fbZ1ps=; b=K/jvKov+O1jct8kMVYRypDVSp9bU9TOGuOidlEA5z3fS3bN6TqbZeN+mst4dtrcdio o0qjj7FCW0tD7Kac225mb/Pb8KzN30Yjy+EuyImcDQwY0ke4SUJ0hcITd2OrOfNizEqM EthFHxKgQB02/vNB8U1Q40aAC6JSUP1oJbPYsVeTKI95d4aWVCwKD1uVaBgKrmRT3fW6 d9sszJotD5gXT/XI0FbtsV18rRrSzmYGH28PdnpHYLxZqzM22/iU1hAYuk46MOT/6FsX /fMDPhn0cEMe/1hYsPSchspjVBRklUdGC0fBDu2WU9VBl48AzBIVLlhVIfHAem7ni5Ge vRhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Q7w2UPgLeSSdRNhD+ocOvYHd/kwU0wfh+wAb1fbZ1ps=; b=tOnauBy+nwv85oKau6reNYggifvSUR/1Fba2Qz8BIiwhaxIMcAEEFc6/ssq4sfo8B6 t1KpZWc5JupDMBbIewJQfQXYzYhJ9vaB6Ku60mEQdFy8AiqTpZd7ZOkfH6YRUlyPVK1+ sEqhJdGCT78CCSQWYZGFSGDD91HvmodM8ao4n2fG1CzcO1uxg9kLm0KR9HBx4U0oRW3q VFPNXsbOoiYsOsF9Ea4fnfx77cSuu6c1l5niV/lHX8Ka85BKz/bs9CumivMEA85Yo12y dhJDVu8UvpR2ZKq4foMCbRJjF7tAWeITBs39RlC10Wuy+ztcjMfYtPCz2F8GMFXJ0s/b fC6A== X-Gm-Message-State: AODbwcAZ5xol+CHIIc+gIlJ4rPH96NTp6XOjA8YgjyCBRj6KrYaXihRH xG9WEeeS7XEtif5K X-Received: by 10.176.4.3 with SMTP id 3mr77462uav.20.1495055242528; Wed, 17 May 2017 14:07:22 -0700 (PDT) Received: from localhost.localdomain ([190.148.214.192]) by smtp.gmail.com with ESMTPSA id v81sm664641vkd.3.2017.05.17.14.07.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 May 2017 14:07:21 -0700 (PDT) From: Daniel Drake To: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com Cc: chiu@endlessm.com, linux@endlessm.com Subject: psmouse: reset during probe? Date: Wed, 17 May 2017 14:59:50 -0600 Message-Id: <20170517205950.27449-1-drake@endlessm.com> X-Mailer: git-send-email 2.11.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, A bunch of new Acer laptops have an EC which expects the PS/2 reset command before the touchpad is initialized. On Linux, that means that currently the touchpad is unresponsive until suspend/resume, when psmouse_reconnect() resets the device. It appears that Windows sends the reset command during boot. Should Linux do the same for all mice here? Thanks Daniel --- drivers/input/mouse/psmouse-base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c index 9f6203c8577c..0e506427ae91 100644 --- a/drivers/input/mouse/psmouse-base.c +++ b/drivers/input/mouse/psmouse-base.c @@ -1546,6 +1546,7 @@ static int psmouse_connect(struct serio *serio, struct serio_driver *drv) psmouse->resync_time = parent ? 0 : psmouse_resync_time; psmouse->smartscroll = psmouse_smartscroll; + psmouse_reset(psmouse); psmouse_switch_protocol(psmouse, NULL); psmouse_set_state(psmouse, PSMOUSE_CMD_MODE);