From patchwork Sat Jun 17 10:58:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 9794051 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4B179600F6 for ; Sat, 17 Jun 2017 10:58:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D4EE284D2 for ; Sat, 17 Jun 2017 10:58:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 32207284DC; Sat, 17 Jun 2017 10:58:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C1583284D2 for ; Sat, 17 Jun 2017 10:58:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbdFQK6m (ORCPT ); Sat, 17 Jun 2017 06:58:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50076 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752720AbdFQK6l (ORCPT ); Sat, 17 Jun 2017 06:58:41 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0DFD8A003; Sat, 17 Jun 2017 10:58:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F0DFD8A003 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com F0DFD8A003 Received: from shalem.localdomain.com (ovpn-116-82.ams2.redhat.com [10.36.116.82]) by smtp.corp.redhat.com (Postfix) with ESMTP id D2B3058840; Sat, 17 Jun 2017 10:58:39 +0000 (UTC) From: Hans de Goede To: Dmitry Torokhov Cc: Hans de Goede , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 3/4] Input: icn8318 - Add support for ACPI enumeration Date: Sat, 17 Jun 2017 12:58:33 +0200 Message-Id: <20170617105834.16255-3-hdegoede@redhat.com> In-Reply-To: <20170617105834.16255-1-hdegoede@redhat.com> References: <20170617105834.16255-1-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sat, 17 Jun 2017 10:58:41 +0000 (UTC) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The icn8505 variant is found on some x86 tablets, which use ACPI enumeration, add support for ACPI enumeration. Signed-off-by: Hans de Goede --- drivers/input/touchscreen/Kconfig | 2 +- drivers/input/touchscreen/chipone_icn8318.c | 67 ++++++++++++++++++++++++++++- 2 files changed, 67 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index fff1467506e7..e3b52d356e13 100644 --- a/drivers/input/touchscreen/Kconfig +++ b/drivers/input/touchscreen/Kconfig @@ -155,7 +155,7 @@ config TOUCHSCREEN_CHIPONE_ICN8318 tristate "chipone icn8318 touchscreen controller" depends on GPIOLIB || COMPILE_TEST depends on I2C - depends on OF + depends on OF || ACPI help Say Y here if you have a ChipOne icn8318 or icn8505 based I2C touchscreen. diff --git a/drivers/input/touchscreen/chipone_icn8318.c b/drivers/input/touchscreen/chipone_icn8318.c index 993df804883f..b209872954f7 100644 --- a/drivers/input/touchscreen/chipone_icn8318.c +++ b/drivers/input/touchscreen/chipone_icn8318.c @@ -12,6 +12,7 @@ * Hans de Goede */ +#include #include #include #include @@ -232,6 +233,66 @@ static int icn8318_probe_of(struct icn8318_data *data, struct device *dev) } #endif +#ifdef CONFIG_ACPI +static const struct acpi_device_id icn8318_acpi_match[] = { + { "CHPN0001", ICN8505 }, + { } +}; +MODULE_DEVICE_TABLE(acpi, icn8318_acpi_match); + +static int icn8318_probe_acpi(struct icn8318_data *data, struct device *dev) +{ + struct acpi_buffer buf = { ACPI_ALLOCATE_BUFFER }; + struct input_dev *input = data->input; + const struct acpi_device_id *id; + struct acpi_device *adev; + acpi_status status; + const char *sub; + + adev = ACPI_COMPANION(dev); + id = acpi_match_device(icn8318_acpi_match, dev); + if (!adev || !id) + return -ENODEV; + + data->model = id->driver_data; + + /* The _SUB ACPI object describes the touchscreen model */ + status = acpi_evaluate_object_typed(adev->handle, "_SUB", NULL, + &buf, ACPI_TYPE_STRING); + if (ACPI_FAILURE(status)) { + dev_err(dev, "ACPI _SUB object not found\n"); + return -ENODEV; + } + sub = ((union acpi_object *)buf.pointer)->string.pointer; + + if (strcmp(sub, "HAMP0002") == 0) { + input_set_abs_params(input, ABS_MT_POSITION_X, 0, 1199, 0, 0); + input_set_abs_params(input, ABS_MT_POSITION_Y, 0, 1919, 0, 0); + } else { + dev_err(dev, "Unknown model _SUB: %s\n", sub); + kfree(buf.pointer); + return -ENODEV; + } + kfree(buf.pointer); + + /* + * Disable ACPI power management the _PS3 method is empty, so + * there is no powersaving when using ACPI power management. + * The _PS0 method resets the controller causing it to loose its + * firmware, which has been loaded by the BIOS and we do not + * know how to restore the firmware. + */ + adev->flags.power_manageable = 0; + + return 0; +} +#else +static int icn8318_probe_acpi(struct icn8318_data *data, struct device *dev) +{ + return -ENODEV; +} +#endif + static int icn8318_probe(struct i2c_client *client) { struct device *dev = &client->dev; @@ -264,7 +325,10 @@ static int icn8318_probe(struct i2c_client *client) input_set_capability(input, EV_ABS, ABS_MT_POSITION_X); input_set_capability(input, EV_ABS, ABS_MT_POSITION_Y); - error = icn8318_probe_of(data, dev); + if (client->dev.of_node) + error = icn8318_probe_of(data, dev); + else + error = icn8318_probe_acpi(data, dev); if (error) return error; @@ -318,6 +382,7 @@ static struct i2c_driver icn8318_driver = { .driver = { .name = "chipone_icn8318", .pm = &icn8318_pm_ops, + .acpi_match_table = ACPI_PTR(icn8318_acpi_match), .of_match_table = icn8318_of_match, }, .probe_new = icn8318_probe,