diff mbox

[v3] Input: goodix: Add support for capacitive home button

Message ID 20170620160835.13904-1-hadess@hadess.net (mailing list archive)
State Accepted
Headers show

Commit Message

Bastien Nocera June 20, 2017, 4:08 p.m. UTC 
From: "Sergei A. Trusov" <sergei.a.trusov@ya.ru>

On some x86 tablets with a Goodix touchscreen, the Windows logo on the
front is a capacitive home button. Touching this button results in a touch
with bit 4 of the first byte set, while only the lower 4 bits (0-3) are
used to indicate the number of touches.

Report a KEY_LEFTMETA press when this happens.

Note that the hardware might support more than one button, in which
case the "id" byte of coor_data would identify the button in question.
This is not implemented as we don't have access to hardware with
multiple buttons.

Signed-off-by: Sergei A. Trusov <sergei.a.trusov@ya.ru>
Acked-by: Bastien Nocera <hadess@hadess.net>
---

Changes from v2:
 - commit message fixes
 - use BIT(4) instead of 0x10

 drivers/input/touchscreen/goodix.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Bastien Nocera Sept. 6, 2017, 9 a.m. UTC | #1 
Hey,

On Tue, 2017-06-20 at 18:08 +0200, Bastien Nocera wrote:
> From: "Sergei A. Trusov" <sergei.a.trusov@ya.ru>
> 
> On some x86 tablets with a Goodix touchscreen, the Windows logo on
> the
> front is a capacitive home button. Touching this button results in a
> touch
> with bit 4 of the first byte set, while only the lower 4 bits (0-3)
> are
> used to indicate the number of touches.
> 
> Report a KEY_LEFTMETA press when this happens.
> 
> Note that the hardware might support more than one button, in which
> case the "id" byte of coor_data would identify the button in
> question.
> This is not implemented as we don't have access to hardware with
> multiple buttons.
> 
> Signed-off-by: Sergei A. Trusov <sergei.a.trusov@ya.ru>
> Acked-by: Bastien Nocera <hadess@hadess.net>

Can we please get this merged? I didn't receive any reviews on it, and
it's been sitting there for 2 months...
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jiri Kosina Sept. 6, 2017, 9:03 a.m. UTC | #2 
On Wed, 6 Sep 2017, Bastien Nocera wrote:

> Hey,
> 
> On Tue, 2017-06-20 at 18:08 +0200, Bastien Nocera wrote:
> > From: "Sergei A. Trusov" <sergei.a.trusov@ya.ru>
> > 
> > On some x86 tablets with a Goodix touchscreen, the Windows logo on
> > the
> > front is a capacitive home button. Touching this button results in a
> > touch
> > with bit 4 of the first byte set, while only the lower 4 bits (0-3)
> > are
> > used to indicate the number of touches.
> > 
> > Report a KEY_LEFTMETA press when this happens.
> > 
> > Note that the hardware might support more than one button, in which
> > case the "id" byte of coor_data would identify the button in
> > question.
> > This is not implemented as we don't have access to hardware with
> > multiple buttons.
> > 
> > Signed-off-by: Sergei A. Trusov <sergei.a.trusov@ya.ru>
> > Acked-by: Bastien Nocera <hadess@hadess.net>
> 
> Can we please get this merged? I didn't receive any reviews on it, and
> it's been sitting there for 2 months...

Let's CC Dmitry.
Dmitry Torokhov Sept. 7, 2017, 12:30 a.m. UTC | #3 
On Wed, Sep 06, 2017 at 11:03:06AM +0200, Jiri Kosina wrote:
> On Wed, 6 Sep 2017, Bastien Nocera wrote:
> 
> > Hey,
> > 
> > On Tue, 2017-06-20 at 18:08 +0200, Bastien Nocera wrote:
> > > From: "Sergei A. Trusov" <sergei.a.trusov@ya.ru>
> > > 
> > > On some x86 tablets with a Goodix touchscreen, the Windows logo on
> > > the
> > > front is a capacitive home button. Touching this button results in a
> > > touch
> > > with bit 4 of the first byte set, while only the lower 4 bits (0-3)
> > > are
> > > used to indicate the number of touches.
> > > 
> > > Report a KEY_LEFTMETA press when this happens.
> > > 
> > > Note that the hardware might support more than one button, in which
> > > case the "id" byte of coor_data would identify the button in
> > > question.
> > > This is not implemented as we don't have access to hardware with
> > > multiple buttons.
> > > 
> > > Signed-off-by: Sergei A. Trusov <sergei.a.trusov@ya.ru>
> > > Acked-by: Bastien Nocera <hadess@hadess.net>
> > 
> > Can we please get this merged? I didn't receive any reviews on it, and
> > it's been sitting there for 2 months...
> 
> Let's CC Dmitry.

Applied, thank you.
diff mbox

Patch

diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 240b16f3ee97..903137d9cf7d 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -267,6 +267,12 @@  static void goodix_process_events(struct goodix_ts_data *ts)
 	if (touch_num < 0)
 		return;
 
+	/*
+	 * Bit 4 of the first byte reports the status of the capacitive
+	 * Windows/Home button.
+	 */
+	input_report_key(ts->input_dev, KEY_LEFTMETA, !!(point_data[0] & BIT(4)));
+
 	for (i = 0; i < touch_num; i++)
 		goodix_ts_report_touch(ts,
 				&point_data[1 + GOODIX_CONTACT_SIZE * i]);
@@ -612,6 +618,9 @@  static int goodix_request_input_dev(struct goodix_ts_data *ts)
 	ts->input_dev->id.product = ts->id;
 	ts->input_dev->id.version = ts->version;
 
+	/* Capacitive Windows/Home button on some devices */
+	input_set_capability(ts->input_dev, EV_KEY, KEY_LEFTMETA);
+
 	error = input_register_device(ts->input_dev);
 	if (error) {
 		dev_err(&ts->client->dev,